[Bug] Return the Bad-Request when deleting the storage if it's used by some volume #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
John-Lin
changed the title
hwchiu
force-pushed
the
hwchiu/fix-wrong-ret
branch
from
994f912 to
052245d
Compare
hwchiu
changed the title
hwchiu
force-pushed
the
hwchiu/fix-wrong-ret
branch
from
052245d to
44d45e1
Compare
hwchiu
force-pushed
the
hwchiu/fix-wrong-ret
branch
from
44d45e1 to
d91527a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #285 +/- ##
===========================================
+ Coverage 78.59% 80.41% +1.82%
===========================================
Files 62 62
Lines 3485 3697 +212
===========================================
+ Hits 2739 2973 +234
+ Misses 564 551 -13
+ Partials 182 173 -9
Continue to review full report at Codecov.
|
John-Lin
commented
Aug 28, 2018
src/server/handler_storage.go
Outdated
| @@ -151,6 +151,10 @@ func deleteStorage(ctx *web.Context) { | |||
| return | |||
| } | |||
|
|
|||
| if err := storageProvider.ValidateBeforeDeleting(sp, &storage); err != nil { | |||
| response.BadRequest(req.Request, resp.ResponseWriter, err) | |||
| } | |||
hwchiu
force-pushed
the
hwchiu/fix-wrong-ret
branch
from
352c87e to
425ad1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.