Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] add auth for namespaces #287

Merged
merged 4 commits into from
Aug 28, 2018
Merged

[Task] add auth for namespaces #287

merged 4 commits into from
Aug 28, 2018

Conversation

John-Lin
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 28, 2018

Codecov Report

Merging #287 into develop will increase coverage by 0.6%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #287     +/-   ##
==========================================
+ Coverage    78.56%   79.16%   +0.6%     
==========================================
  Files           60       60             
  Lines         3401     3475     +74     
==========================================
+ Hits          2672     2751     +79     
+ Misses         553      552      -1     
+ Partials       176      172      -4
Impacted Files Coverage Δ
src/server/route.go 84.92% <100%> (+0.12%) ⬆️
src/server/handler_namespace.go 68.37% <66.66%> (-0.15%) ⬇️
src/prometheuscontroller/controller.go 88.9% <0%> (+2.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed520c...1bd884b. Read the comment docs.

@John-Lin John-Lin merged commit 0da5f51 into develop Aug 28, 2018
@John-Lin John-Lin deleted the johnlin/namespace-auth branch August 28, 2018 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants