DEV: Phstsai/prometheus client #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchiu
suggested changes
Jun 22, 2018
hwchiu
suggested changes
Jun 22, 2018
There was a problem hiding this comment.
Follow the https://github.com/prometheus/client_golang/blob/7540c0707421d7c58cfce34f4294d1b1f25f240d/api/prometheus/v1/api_test.go to write the testing for prometheus and you can push it on the other PR
Codecov Report
@@ Coverage Diff @@
## develop #29 +/- ##
===========================================
+ Coverage 77.8% 78.61% +0.81%
===========================================
Files 16 17 +1
Lines 428 449 +21
===========================================
+ Hits 333 353 +20
- Misses 73 74 +1
Partials 22 22
Continue to review full report at Codecov.
|
|
這個rebase怪怪的lol |
hwchiu
force-pushed
the
phstsai/prometheus-client
branch
from
410f328 to
95522cc
Compare
John-Lin
approved these changes
Jun 26, 2018
hwchiu
suggested changes
Jun 26, 2018
| api prometheus.API | ||
| } | ||
|
|
||
| func (suite *PrometheusTestSuite) SetupTest() { |
| suite.Run(t, new(PrometheusTestSuite)) | ||
| } | ||
|
|
||
| func (suite *PrometheusTestSuite) TearDownTest() { |
|
|
||
| func (suite *PrometheusTestSuite) SetupTest() { | ||
| cf := config.MustRead("../../config/testing.json") | ||
| sp := serviceprovider.New(cf) |
There was a problem hiding this comment.
Change to serviceprovider.NewForTesting(t) to avoid the k8s config init.
- For travis - Install OpenvSwitch - Run a gRPC server - Use the sudo to run the testing (we need to create a veth for testing) - For testing - Use the suite to wrapper the common variable for all testing.
WakeupTsai
force-pushed
the
phstsai/prometheus-client
branch
from
fc243f9 to
645cf2a
Compare
hwchiu
approved these changes
Jun 27, 2018
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
DEV: Phstsai/prometheus client Former-commit-id: c89a669ec579d4ed9af275652266b3ccb828acf8 [formerly 4481511] Former-commit-id: 35060b6ecc503a15499dbc6277857d0fc2d16ce7
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
DEV: Phstsai/prometheus client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.