Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "[Bug] VX-280: GetContainer API should require pod name"" #293

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

WakeupTsai
Copy link
Contributor

No description provided.

@WakeupTsai WakeupTsai requested a review from John-Lin August 29, 2018 05:52
@codecov-io
Copy link

codecov-io commented Aug 29, 2018

Codecov Report

Merging #293 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #293      +/-   ##
==========================================
+ Coverage    78.46%   78.5%   +0.03%     
==========================================
  Files           62      62              
  Lines         3492    3470      -22     
==========================================
- Hits          2740    2724      -16     
+ Misses         569     565       -4     
+ Partials       183     181       -2
Impacted Files Coverage Δ
src/prometheuscontroller/controller.go 86.04% <100%> (ø) ⬆️
src/server/route.go 84.96% <100%> (-0.12%) ⬇️
src/server/handler_prometheus.go 65.57% <100%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d29be41...3f33579. Read the comment docs.

@John-Lin John-Lin merged commit c7caeb7 into develop Aug 29, 2018
@John-Lin John-Lin deleted the revert-290-revert-282-phstsai/VX-280 branch August 29, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants