Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Support the PodName and InterfaceName of OVSPortInfo query. #297

Merged
merged 7 commits into from
Aug 31, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Aug 30, 2018

The output will looks like below.
screen shot 2018-08-30 at 10 26 10 am

The PortId is what user need to handle in the openflow rules and the portID(-1) is bridge itself, the caller can ignore it.

@hwchiu hwchiu requested review from John-Lin and chenyunchen August 30, 2018 03:42
@hwchiu hwchiu force-pushed the hwchiu/return-ovs-port branch from d6e8c78 to 7fe7640 Compare August 30, 2018 03:57
@codecov-io
Copy link

codecov-io commented Aug 30, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@8b37c4a). Click here to learn what that means.
The diff coverage is 63.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #297   +/-   ##
==========================================
  Coverage           ?   75.61%           
==========================================
  Files              ?       63           
  Lines              ?     3679           
  Branches           ?        0           
==========================================
  Hits               ?     2782           
  Misses             ?      696           
  Partials           ?      201
Impacted Files Coverage Δ
src/networkcontroller/network_controller.go 81.81% <100%> (ø)
src/kubernetes/pods.go 90% <100%> (ø)
src/server/route.go 84.96% <100%> (ø)
src/server/handler_ovs.go 93.75% <100%> (ø)
src/ovscontroller/ovs_system.go 59.32% <59.25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b37c4a...230f82f. Read the comment docs.

@hwchiu hwchiu force-pushed the hwchiu/return-ovs-port branch from 7fe7640 to 1408c82 Compare August 31, 2018 08:35
@John-Lin John-Lin merged commit a53be40 into develop Aug 31, 2018
@John-Lin John-Lin deleted the hwchiu/return-ovs-port branch September 1, 2018 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants