Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network controller #30

Merged
merged 11 commits into from
Jun 26, 2018
Merged

Add network controller #30

merged 11 commits into from
Jun 26, 2018

Conversation

chenyunchen
Copy link
Contributor

No description provided.

@hwchiu hwchiu requested a review from WakeupTsai June 23, 2018 05:08
@John-Lin
Copy link
Contributor

John-Lin commented Jun 23, 2018

Rename to networkcontroller/network_controller.go

Sent with GitHawk

@John-Lin
Copy link
Contributor

@chenyunchen rebase develop branch 再修一下,現在多了 getNodeExternaIP了,但要用物件方法

@chenyunchen chenyunchen force-pushed the alex/network-controller branch 8 times, most recently from 3717750 to 016c537 Compare June 25, 2018 10:22
@codecov-io
Copy link

codecov-io commented Jun 26, 2018

Codecov Report

Merging #30 into develop will decrease coverage by 1.78%.
The diff coverage is 62.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #30      +/-   ##
==========================================
- Coverage    79.58%   77.8%   -1.79%     
==========================================
  Files           15      16       +1     
  Lines          387     428      +41     
==========================================
+ Hits           308     333      +25     
- Misses          63      73      +10     
- Partials        16      22       +6
Impacted Files Coverage Δ
src/server/handler_network.go 81% <27.27%> (-6.92%) ⬇️
src/networkcontroller/network_controller.go 75% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eb4d3e...1e968e6. Read the comment docs.

@hwchiu hwchiu requested review from John-Lin and sufuf3 June 26, 2018 05:27
@chenyunchen chenyunchen force-pushed the alex/network-controller branch 2 times, most recently from 6996ac8 to a082950 Compare June 26, 2018 08:55
@hwchiu hwchiu force-pushed the alex/network-controller branch 2 times, most recently from 6082de3 to 60c3406 Compare June 26, 2018 09:32
@hwchiu hwchiu force-pushed the alex/network-controller branch from 60c3406 to 1e968e6 Compare June 26, 2018 09:41
@John-Lin John-Lin merged commit dd01cbf into develop Jun 26, 2018
@hwchiu hwchiu deleted the alex/network-controller branch June 26, 2018 10:06
John-Lin added a commit that referenced this pull request Jul 25, 2018
Add network controller

Former-commit-id: c0298a16614b2adc44cafd777b4270d2c2bcec08 [formerly dd01cbf]
Former-commit-id: b983b59baae23791621a1de3f22c9176c76f9632
John-Lin added a commit that referenced this pull request Jul 25, 2018
Add network controller

Former-commit-id: c0298a16614b2adc44cafd777b4270d2c2bcec08 [formerly c0298a16614b2adc44cafd777b4270d2c2bcec08 [formerly dd01cbf]]
Former-commit-id: b983b59baae23791621a1de3f22c9176c76f9632
Former-commit-id: 7069fbe
John-Lin added a commit that referenced this pull request Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants