Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] add image pull secret #302

Merged
merged 1 commit into from
Sep 1, 2018
Merged

[Task] add image pull secret #302

merged 1 commit into from
Sep 1, 2018

Conversation

John-Lin
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 31, 2018

Codecov Report

Merging #302 into develop will increase coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #302     +/-   ##
==========================================
+ Coverage    75.55%   75.86%   +0.3%     
==========================================
  Files           63       63             
  Lines         3682     3720     +38     
==========================================
+ Hits          2782     2822     +40     
+ Misses         699      698      -1     
+ Partials       201      200      -1
Impacted Files Coverage Δ
src/deployment/deployment.go 94.69% <100%> (+0.07%) ⬆️
src/pod/pod.go 97.11% <100%> (+0.04%) ⬆️
src/server/route.go 86.01% <0%> (+1.05%) ⬆️
src/server/handler_app.go 68.42% <0%> (+16.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6233407...7bcad55. Read the comment docs.

@John-Lin John-Lin force-pushed the johnlin/imagepullsecret branch from 2a4ee16 to c5fcfcb Compare August 31, 2018 09:13
@John-Lin John-Lin force-pushed the johnlin/imagepullsecret branch from c5fcfcb to 7bcad55 Compare September 1, 2018 04:48
@John-Lin John-Lin merged commit 99bdb48 into develop Sep 1, 2018
@John-Lin John-Lin deleted the johnlin/imagepullsecret branch September 1, 2018 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants