Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] hashed default user password #307

Merged
merged 1 commit into from
Sep 1, 2018

Conversation

John-Lin
Copy link
Contributor

No description provided.

@John-Lin John-Lin requested a review from hwchiu August 31, 2018 17:01
@John-Lin John-Lin force-pushed the johnlin/hash-default-admin-password branch from 87b7cd7 to 5e8862d Compare August 31, 2018 17:27
@codecov-io
Copy link

codecov-io commented Sep 1, 2018

Codecov Report

Merging #307 into develop will decrease coverage by 0.06%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #307      +/-   ##
===========================================
- Coverage    75.61%   75.55%   -0.07%     
===========================================
  Files           63       63              
  Lines         3679     3682       +3     
===========================================
  Hits          2782     2782              
- Misses         696      699       +3     
  Partials       201      201
Impacted Files Coverage Δ
src/utils/password.go 100% <ø> (ø)
src/serviceprovider/default_admin.go 0% <0%> (ø) ⬆️
src/server/backend/authenticate.go 83.33% <100%> (ø) ⬆️
src/server/handler_user.go 70.85% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f089d...4eed268. Read the comment docs.

@John-Lin John-Lin force-pushed the johnlin/hash-default-admin-password branch from b952417 to 4eed268 Compare September 1, 2018 04:31
@John-Lin John-Lin merged commit 6233407 into develop Sep 1, 2018
@John-Lin John-Lin deleted the johnlin/hash-default-admin-password branch September 1, 2018 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants