Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] upload deployment yaml #310

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Conversation

John-Lin
Copy link
Contributor

@John-Lin John-Lin commented Sep 3, 2018

No description provided.

@John-Lin John-Lin force-pushed the johnlin/upload-deployment-yaml branch from e984a65 to 617844e Compare September 5, 2018 06:44
@codecov-io
Copy link

codecov-io commented Sep 5, 2018

Codecov Report

Merging #310 into develop will decrease coverage by 1.29%.
The diff coverage is 1.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #310     +/-   ##
==========================================
- Coverage    75.56%   74.26%   -1.3%     
==========================================
  Files           63       64      +1     
  Lines         3700     3766     +66     
==========================================
+ Hits          2796     2797      +1     
- Misses         701      766     +65     
  Partials       203      203
Impacted Files Coverage Δ
src/deployment/deployment.go 94.69% <ø> (ø) ⬆️
src/kubernetes/yaml.go 0% <0%> (ø)
src/server/handler_deployment.go 45.35% <0%> (-21.59%) ⬇️
src/server/route.go 85.18% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61bcfac...ad78ece. Read the comment docs.

@John-Lin John-Lin force-pushed the johnlin/upload-deployment-yaml branch from 4a25ec8 to ad78ece Compare September 6, 2018 06:46
@John-Lin
Copy link
Contributor Author

John-Lin commented Sep 7, 2018

測試候補

@John-Lin John-Lin merged commit 8d2f93c into develop Sep 7, 2018
@hwchiu
Copy link
Contributor

hwchiu commented Sep 7, 2018

restful內那些跟deployment的能的話還是往下放到 src/deployment 之類的,讓 restful 的邏輯簡單

@John-Lin John-Lin deleted the johnlin/upload-deployment-yaml branch September 18, 2018 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants