Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] update password #318

Merged
merged 5 commits into from
Sep 20, 2018
Merged

[Task] update password #318

merged 5 commits into from
Sep 20, 2018

Conversation

John-Lin
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 20, 2018

Codecov Report

Merging #318 into develop will decrease coverage by 0.15%.
The diff coverage is 47.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #318      +/-   ##
===========================================
- Coverage    71.37%   71.22%   -0.16%     
===========================================
  Files           66       66              
  Lines         4080     4180     +100     
===========================================
+ Hits          2912     2977      +65     
- Misses         937      956      +19     
- Partials       231      247      +16
Impacted Files Coverage Δ
src/server/route.go 81.5% <100%> (+0.12%) ⬆️
src/server/handler_user.go 66.35% <46.15%> (-4.51%) ⬇️
src/namespace/namespace.go 89.47% <0%> (-10.53%) ⬇️
src/net/http/response.go 89.36% <0%> (-3.98%) ⬇️
src/server/handler_namespace.go 65.47% <0%> (+3.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f53b5...c5d027a. Read the comment docs.

@John-Lin John-Lin force-pushed the johnlin/update-password branch from 30d4ce7 to c409ad5 Compare September 20, 2018 05:25
Copy link
Contributor

@WakeupTsai WakeupTsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should check owner of the user

@John-Lin
Copy link
Contributor Author

Add documents

@John-Lin John-Lin merged commit 5a6b86d into develop Sep 20, 2018
@John-Lin John-Lin deleted the johnlin/update-password branch September 20, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants