Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Allow mount configMaps when creating deployment #330

Merged
merged 2 commits into from
Sep 26, 2018

Conversation

WakeupTsai
Copy link
Contributor

No description provided.

@WakeupTsai WakeupTsai force-pushed the phstsai/configmap-deployment branch from 2cee158 to 47f824c Compare September 26, 2018 10:08
@codecov-io
Copy link

Codecov Report

Merging #330 into develop will increase coverage by 0.11%.
The diff coverage is 92%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #330      +/-   ##
===========================================
+ Coverage    71.16%   71.27%   +0.11%     
===========================================
  Files           65       65              
  Lines         4161     4184      +23     
===========================================
+ Hits          2961     2982      +21     
- Misses         960      961       +1     
- Partials       240      241       +1
Impacted Files Coverage Δ
src/deployment/deployment.go 89.73% <92%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab2aa7...47f824c. Read the comment docs.

@John-Lin
Copy link
Contributor

Thanks

@John-Lin John-Lin merged commit 92b38bd into develop Sep 26, 2018
@John-Lin John-Lin deleted the phstsai/configmap-deployment branch September 27, 2018 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants