[Task] autoscaler API #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #331 +/- ##
==========================================
Coverage ? 70.77%
==========================================
Files ? 70
Lines ? 4499
Branches ? 0
==========================================
Hits ? 3184
Misses ? 1051
Partials ? 264
Continue to review full report at Codecov.
|
John-Lin
force-pushed
the
johnlin/autoscaler
branch
3 times, most recently
from
842a85e to
2234332
Compare
John-Lin
force-pushed
the
johnlin/autoscaler
branch
from
3f36b8c to
715b8a1
Compare
WakeupTsai
reviewed
Oct 1, 2018
src/kubernetes/autoscaler.go
Outdated
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| ) | ||
|
|
||
| // CreateAutoscaler will get the external IP address of node |
There was a problem hiding this comment.
why autoscaler needs the external IP of node ?
WakeupTsai
reviewed
Oct 1, 2018
| } | ||
|
|
||
| // DeleteAutoscaler will delete a autoscaler | ||
| func DeleteAutoscaler(sp *serviceprovider.Container, autoscalerInfo entity.AutoscalerInfo) error { |
There was a problem hiding this comment.
Will autoscaler delete itself while the corresponding deployment is been removed ?
John-Lin
force-pushed
the
johnlin/autoscaler
branch
2 times, most recently
from
8d76eb6 to
d45d703
Compare
John-Lin
force-pushed
the
johnlin/autoscaler
branch
from
4b6e04b to
208ca4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.