[Task] ConfigMap API #334
Merged
[Task] ConfigMap API #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
John-Lin
reviewed
Sep 28, 2018
src/entity/configMap.go
Outdated
| OwnerID bson.ObjectId `bson:"ownerID,omitempty" json:"ownerID" validate:"-"` | ||
| Name string `bson:"name" json:"name" validate:"required,k8sname"` | ||
| Namespace string `bson:"namespace" json:"namespace" validate:"required"` | ||
| Data map[string]string `json:"data,omitempty" protobuf:"bytes,2,rep,name=data"` |
There was a problem hiding this comment.
We don’t use protobuf as json tag
Codecov Report
@@ Coverage Diff @@
## develop #334 +/- ##
===========================================
- Coverage 71.27% 71.01% -0.26%
===========================================
Files 65 68 +3
Lines 4184 4406 +222
===========================================
+ Hits 2982 3129 +147
- Misses 961 1019 +58
- Partials 241 258 +17
Continue to review full report at Codecov.
|
WakeupTsai
force-pushed
the
phstsai/configmap-deployment
branch
2 times, most recently
from
55028d2 to
2e684cd
Compare
WakeupTsai
force-pushed
the
phstsai/configmap-deployment
branch
from
2e684cd to
d79c139
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.