Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused package from vendor #34

Merged
merged 1 commit into from
Jun 23, 2018
Merged

remove unused package from vendor #34

merged 1 commit into from
Jun 23, 2018

Conversation

John-Lin
Copy link
Contributor

simple command to remove unused package from vendor.json

govendor remove +unused

@codecov-io
Copy link

Codecov Report

Merging #34 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop     #34   +/-   ##
=======================================
  Coverage     60.8%   60.8%           
=======================================
  Files           13      13           
  Lines          347     347           
=======================================
  Hits           211     211           
  Misses         124     124           
  Partials        12      12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4131bfe...4f87a61. Read the comment docs.

@John-Lin John-Lin requested review from chenyunchen and WakeupTsai and removed request for chenyunchen June 23, 2018 10:21
hwchiu
hwchiu approved these changes Jun 23, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwchiu hwchiu merged commit b312705 into develop Jun 23, 2018
@John-Lin John-Lin deleted the johnlin/remove-unused-deps branch June 23, 2018 10:48
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #34 from linkernetworks/johnlin/remove-unused-deps
7009d84 
remove unused package from vendor

Former-commit-id: ede38e7007569d1598ad6b04ea59d4a4cdf61e16 [formerly b312705]
Former-commit-id: a14c090b11f7a4c1051e70972aba0c86b63f9a52
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #34 from linkernetworks/johnlin/remove-unused-deps
809fdc8 
remove unused package from vendor

Former-commit-id: ede38e7007569d1598ad6b04ea59d4a4cdf61e16 [formerly ede38e7007569d1598ad6b04ea59d4a4cdf61e16 [formerly b312705]]
Former-commit-id: a14c090b11f7a4c1051e70972aba0c86b63f9a52
Former-commit-id: 7009d84
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #34 from linkernetworks/johnlin/remove-unused-deps
427e78e 
remove unused package from vendor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@WakeupTsai WakeupTsai Awaiting requested review from WakeupTsai

@chenyunchen chenyunchen Awaiting requested review from chenyunchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@John-Lin @codecov-io @hwchiu