Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the goreports. #38

Merged
merged 4 commits into from
Jun 24, 2018
Merged

Fix the goreports. #38

merged 4 commits into from
Jun 24, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jun 24, 2018

Fix following issues
GoFmt
Go_Vet

  • Unused example (Wrong function name and usage)
    GoLint
  • Commend function or change to private function (not-exposed)

@hwchiu hwchiu force-pushed the hwchiu/goreports branch from 57692a2 to 1dde7c3 Compare June 24, 2018 08:20
@codecov-io
Copy link

Codecov Report

Merging #38 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #38   +/-   ##
========================================
  Coverage    62.32%   62.32%           
========================================
  Files           14       14           
  Lines          361      361           
========================================
  Hits           225      225           
  Misses         124      124           
  Partials        12       12
Impacted Files Coverage Δ
src/kubernetes/kubectl.go 100% <ø> (ø) ⬆️
src/kubernetes/nodes.go 90% <ø> (ø) ⬆️
src/net/http/response.go 93.02% <ø> (ø) ⬆️
src/net/http/query/query.go 100% <ø> (ø) ⬆️
src/net/http/handler.go 100% <ø> (ø) ⬆️
src/server/handler_version.go 0% <0%> (ø) ⬆️
src/server/route.go 50% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1768230...1dde7c3. Read the comment docs.

@hwchiu hwchiu merged commit c3f872e into develop Jun 24, 2018
@hwchiu hwchiu deleted the hwchiu/goreports branch June 24, 2018 09:11
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #38 from linkernetworks/hwchiu/goreports
369b72b 
Fix the goreports.

Former-commit-id: 12b57558d8310428964825233f21de7b3fcf72c7 [formerly c3f872e]
Former-commit-id: fe0d819558d973f2868e941a12f243830308913c
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #38 from linkernetworks/hwchiu/goreports
9f8d8f5 
Fix the goreports.

Former-commit-id: 12b57558d8310428964825233f21de7b3fcf72c7 [formerly 12b57558d8310428964825233f21de7b3fcf72c7 [formerly c3f872e]]
Former-commit-id: fe0d819558d973f2868e941a12f243830308913c
Former-commit-id: 369b72b
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #38 from linkernetworks/hwchiu/goreports
bbe2aaa 
Fix the goreports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Lin John-Lin John-Lin approved these changes

@chenyunchen chenyunchen chenyunchen approved these changes

@sufuf3 sufuf3 Awaiting requested review from sufuf3

@WakeupTsai WakeupTsai Awaiting requested review from WakeupTsai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hwchiu @codecov-io @John-Lin @chenyunchen