Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the testing for invalid page and unexposed the restful handler #39

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Add the testing for invalid page and unexposed the restful handler #39

merged 1 commit into from
Jun 25, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jun 24, 2018

No description provided.

@hwchiu hwchiu force-pushed the hwchiu/minor-fix branch from 80c855f to 60df99b Compare June 24, 2018 12:28
@codecov-io
Copy link

codecov-io commented Jun 24, 2018 •
edited
Loading

Codecov Report

Merging #39 into develop will increase coverage by 0.8%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop      #39     +/-   ##
==========================================
+ Coverage    78.43%   79.24%   +0.8%     
==========================================
  Files           15       15             
  Lines          371      371             
==========================================
+ Hits           291      294      +3     
+ Misses          66       62      -4     
- Partials        14       15      +1
Impacted Files Coverage Δ
src/server/handler_network.go 87.91% <100%> (+3.29%) ⬆️
src/server/handler_storage_provider.go 87.71% <100%> (ø) ⬆️
src/server/route.go 55.88% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 004f168...2deaaaf. Read the comment docs.

@hwchiu hwchiu requested a review from sufuf3 June 25, 2018 02:54
@hwchiu hwchiu force-pushed the hwchiu/minor-fix branch from 60df99b to 2deaaaf Compare June 25, 2018 08:07
@hwchiu hwchiu merged commit 057ca64 into develop Jun 25, 2018
@hwchiu hwchiu deleted the hwchiu/minor-fix branch June 25, 2018 08:22
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #39 from linkernetworks/hwchiu/minor-fix
4c04bba 
Add the testing for invalid page and unexposed the restful handler

Former-commit-id: 7f5e8683b9236d603763adeb6b05c08d10b3568e [formerly 057ca64]
Former-commit-id: 204e6b8583a86aafba61bc4e6cdb25a1f0039deb
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #39 from linkernetworks/hwchiu/minor-fix
647fcbb 
Add the testing for invalid page and unexposed the restful handler

Former-commit-id: 7f5e8683b9236d603763adeb6b05c08d10b3568e [formerly 7f5e8683b9236d603763adeb6b05c08d10b3568e [formerly 057ca64]]
Former-commit-id: 204e6b8583a86aafba61bc4e6cdb25a1f0039deb
Former-commit-id: 4c04bba
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #39 from linkernetworks/hwchiu/minor-fix
7f27a56 
Add the testing for invalid page and unexposed the restful handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Lin John-Lin John-Lin approved these changes

@sufuf3 sufuf3 sufuf3 approved these changes

@chenyunchen chenyunchen Awaiting requested review from chenyunchen

@WakeupTsai WakeupTsai Awaiting requested review from WakeupTsai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hwchiu @codecov-io @John-Lin @sufuf3