Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix volume testing, change assert to suite #42

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Fix volume testing, change assert to suite #42

merged 1 commit into from
Jun 26, 2018

Conversation

chenyunchen
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #42 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #42   +/-   ##
========================================
  Coverage    79.24%   79.24%           
========================================
  Files           15       15           
  Lines          371      371           
========================================
  Hits           294      294           
  Misses          62       62           
  Partials        15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 057ca64...6ca7f3a. Read the comment docs.

@hwchiu hwchiu requested review from John-Lin and hwchiu June 26, 2018 04:26
@hwchiu hwchiu requested review from sufuf3 and WakeupTsai June 26, 2018 05:33
@hwchiu hwchiu merged commit 2b8ddfb into develop Jun 26, 2018
@hwchiu hwchiu deleted the alex/fixVolumeTest branch June 26, 2018 05:47
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #42 from linkernetworks/alex/fixVolumeTest
8264515 
Fix volume testing, change assert to suite

Former-commit-id: 2308fbf3b1a307274239a604a5ea2e2ca05a82c7 [formerly 2b8ddfb]
Former-commit-id: 23f4e3f3680f19311be0b4ce6da996d239a42f30
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #42 from linkernetworks/alex/fixVolumeTest
f1c4c87 
Fix volume testing, change assert to suite

Former-commit-id: 2308fbf3b1a307274239a604a5ea2e2ca05a82c7 [formerly 2308fbf3b1a307274239a604a5ea2e2ca05a82c7 [formerly 2b8ddfb]]
Former-commit-id: 23f4e3f3680f19311be0b4ce6da996d239a42f30
Former-commit-id: 8264515
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #42 from linkernetworks/alex/fixVolumeTest
e659282 
Fix volume testing, change assert to suite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@WakeupTsai WakeupTsai WakeupTsai approved these changes

@John-Lin John-Lin Awaiting requested review from John-Lin

@sufuf3 sufuf3 Awaiting requested review from sufuf3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenyunchen @codecov-io @hwchiu @WakeupTsai