Update deployment config #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchiu
reviewed
Jun 26, 2018
Codecov Report
@@ Coverage Diff @@
## develop #43 +/- ##
==========================================
+ Coverage 79.58% 82.3% +2.72%
==========================================
Files 15 23 +8
Lines 387 684 +297
==========================================
+ Hits 308 563 +255
- Misses 63 89 +26
- Partials 16 32 +16
Continue to review full report at Codecov.
|
John-Lin
approved these changes
Jun 26, 2018
zyfdegh
approved these changes
Jul 4, 2018
chechiachang
commented
Jul 4, 2018
| secretName: heketi-admin-secret | ||
| secretNamespace: default | ||
| volumetype: replicate:2 | ||
| provisioner: kubernetes.io/glusterfs |
There was a problem hiding this comment.
Move storage class to vortex installer.
The storage class should be applied right after kubernetes is up.
chechiachang
commented
Jul 4, 2018
| storageClassName: "manual" | ||
| resources: | ||
| requests: | ||
| storage: 10Gi |
There was a problem hiding this comment.
Duplicate mongo/statefulset
dev -> manual for local testing
default -> slow-many for production
John-Lin
added a commit
that referenced
this pull request
Jul 25, 2018
Update deployment config Former-commit-id: c40a9eed6b2fb32408855b6ead7c2ca4ae15e82e [formerly 8fbbaa3] Former-commit-id: acf620fdf8fe662122b576e44185d5e948ffcd0f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.