Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storage provider testing #45

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Fix storage provider testing #45

merged 1 commit into from
Jun 27, 2018

Conversation

chenyunchen
Copy link
Contributor

No description provided.

@chenyunchen chenyunchen force-pushed the alex/FixStorageProviderTest branch from 989b25a to 8f3c60d Compare June 26, 2018 10:23
@codecov-io
Copy link

codecov-io commented Jun 26, 2018 •
edited
Loading

Codecov Report

Merging #45 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop     #45   +/-   ##
=======================================
  Coverage     77.8%   77.8%           
=======================================
  Files           16      16           
  Lines          428     428           
=======================================
  Hits           333     333           
  Misses          73      73           
  Partials        22      22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd01cbf...8148882. Read the comment docs.

@chenyunchen chenyunchen force-pushed the alex/FixStorageProviderTest branch 3 times, most recently from 0b5b7f9 to c8f5240 Compare June 26, 2018 10:59
@hwchiu
Copy link
Contributor

hwchiu commented Jun 26, 2018 •
edited
Loading

怪怪的，你整個檔案好像都沒有跑進去
@John-Lin 你上次也有遇到這個問題?

@John-Lin
Copy link
Contributor

沒寫suite.Run 測試不會跑

John-Lin
John-Lin suggested changes Jun 27, 2018
View reviewed changes
Copy link
Contributor

@John-Lin John-Lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add suite.Run(t, new(MyTestSuite))

@chenyunchen chenyunchen force-pushed the alex/FixStorageProviderTest branch from c8f5240 to 8148882 Compare June 27, 2018 02:52
@hwchiu hwchiu merged commit 87bbdaa into develop Jun 27, 2018
@hwchiu hwchiu deleted the alex/FixStorageProviderTest branch June 27, 2018 04:03
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #45 from linkernetworks/alex/FixStorageProviderTest
2f33dce 
Fix storage provider testing

Former-commit-id: 91bc560418f67d7d124b891614565fa32b290a73 [formerly 87bbdaa]
Former-commit-id: 3a278731f57c2d2174ff8eeb4ebd19b15ddc41a4
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #45 from linkernetworks/alex/FixStorageProviderTest
24fbc1c 
Fix storage provider testing

Former-commit-id: 91bc560418f67d7d124b891614565fa32b290a73 [formerly 91bc560418f67d7d124b891614565fa32b290a73 [formerly 87bbdaa]]
Former-commit-id: 3a278731f57c2d2174ff8eeb4ebd19b15ddc41a4
Former-commit-id: 2f33dce
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #45 from linkernetworks/alex/FixStorageProviderTest
0005d0c 
Fix storage provider testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@John-Lin John-Lin John-Lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenyunchen @codecov-io @hwchiu @John-Lin