Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the testing condition for prometheus #51

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Add the testing condition for prometheus #51

merged 1 commit into from
Jun 27, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jun 27, 2018

  • Use the environment TEST_PROMETHEUS to check do we need to test the function of prometheus

@hwchiu hwchiu force-pushed the hwchiu/fix-test branch from 5f16a89 to 8f64c9d Compare June 27, 2018 07:27
@hwchiu hwchiu force-pushed the hwchiu/fix-test branch from 8f64c9d to ab2e1ce Compare June 27, 2018 08:25
@codecov-io
Copy link

codecov-io commented Jun 27, 2018 •
edited
Loading

Codecov Report

Merging #51 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #51   +/-   ##
========================================
  Coverage    78.96%   78.96%           
========================================
  Files           17       17           
  Lines          466      466           
========================================
  Hits           368      368           
  Misses          75       75           
  Partials        23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4481511...ab2e1ce. Read the comment docs.

@John-Lin John-Lin merged commit 8c31223 into develop Jun 27, 2018
@John-Lin John-Lin deleted the hwchiu/fix-test branch June 28, 2018 09:23
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #51 from linkernetworks/hwchiu/fix-test
73964ce 
Add the testing condition for prometheus

Former-commit-id: acdb4e4212d1ac6eb182cc7148d42a507ab9711c [formerly 8c31223]
Former-commit-id: 7a16659986fd9a4e90776f6629cebcafcf78108e
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #51 from linkernetworks/hwchiu/fix-test
3fe1b72 
Add the testing condition for prometheus

Former-commit-id: acdb4e4212d1ac6eb182cc7148d42a507ab9711c [formerly acdb4e4212d1ac6eb182cc7148d42a507ab9711c [formerly 8c31223]]
Former-commit-id: 7a16659986fd9a4e90776f6629cebcafcf78108e
Former-commit-id: 73964ce
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #51 from linkernetworks/hwchiu/fix-test
478258f 
Add the testing condition for prometheus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Lin John-Lin John-Lin approved these changes

@sufuf3 sufuf3 sufuf3 approved these changes

@WakeupTsai WakeupTsai WakeupTsai approved these changes

@chenyunchen chenyunchen Awaiting requested review from chenyunchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hwchiu @codecov-io @John-Lin @sufuf3 @WakeupTsai