Refactor the network to support different kind of network implementation #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #53 +/- ##
===========================================
+ Coverage 76.89% 80.56% +3.67%
===========================================
Files 17 20 +3
Lines 528 566 +38
===========================================
+ Hits 406 456 +50
+ Misses 92 83 -9
+ Partials 30 27 -3
Continue to review full report at Codecov.
|
added 10 commits
June 29, 2018 03:09
Provide a new interface networkprovider and every network should implement its funcion now. For the entitu.Network, the restful only cares the basic limtation of document and each network provide should validate its parameters from the requests.
hwchiu
changed the title
Also refine the testing approach of listing network.
John-Lin
approved these changes
Jun 29, 2018
chenyunchen
approved these changes
Jun 29, 2018
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
Refactor the network to support different kind of network implementation Former-commit-id: 7606cac98dd2df5a20e0f6758adb13f9c9a719e2 [formerly 58af7ad] Former-commit-id: 408574af611fa3402694fb4cf469fd409bba7c4d
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
Refactor the network to support different kind of network implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.