Support two types of network. #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyfdegh
reviewed
Jul 2, 2018
src/entity/network.go
Outdated
| NodeName string `bson:"nodeName,omitempty" json:"nodeName,omitempty"` | ||
| CreatedAt *time.Time `bson:"createdAt,omitempty" json:"createdAt,omitempty"` | ||
| OVS OVSNetwork `bson:"ovs,omitempty" json:"ovs"` | ||
| Fake FakeNetwork `bson:"fake,omitempty" json:"fake"` //FakeNetwork, for restful testing. |
There was a problem hiding this comment.
We don't need a BSON tag for field Fake
zyfdegh
reviewed
Jul 2, 2018
| BridgeName: tName, | ||
| PhysicalPorts: []entity.PhysicalPort{}, | ||
| }, | ||
| Type: "ovs", |
There was a problem hiding this comment.
We'd better use type definition for Network.Type in case of typos and invalid values.
type NetworkType string
var OVSNetwork = NetworkType("ovs")
...What do you think?
There was a problem hiding this comment.
That's good, I will modify that.
zyfdegh
reviewed
Jul 3, 2018
|
|
||
| const ( | ||
| OVSNetworkType NetworkType = "ovs" | ||
| FakeNetworkType NetworkType = "fake" |
zyfdegh
approved these changes
Jul 3, 2018
Codecov Report
@@ Coverage Diff @@
## develop #55 +/- ##
==========================================
- Coverage 80.91% 80.4% -0.52%
==========================================
Files 20 20
Lines 566 592 +26
==========================================
+ Hits 458 476 +18
- Misses 81 85 +4
- Partials 27 31 +4
Continue to review full report at Codecov.
|
John-Lin
approved these changes
Jul 3, 2018
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
Support two types of network. Former-commit-id: 5d65bdb1f51bd2d67260b67bd81bd302d0c6e210 [formerly 002ce61] Former-commit-id: ba8e482cafcf8757fd9333597af0fc30f6616bad
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
Support two types of network.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the network, we should support the cluster/single network.
For cluster network, it should create network for all nodes. Otherwise use the nodename from the parameter.