VX-149 VX-150 Add k8s pod, service, pvc: get list create delete function #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyunchen
changed the title
chenyunchen
force-pushed
the
alex/addk8sfunction
branch
from
4dae7da to
d6fcabe
Compare
chenyunchen
changed the title
hwchiu
approved these changes
Jul 4, 2018
src/kubernetes/pvc.go
Outdated
|
|
||
| //Create the PVC by the PVC object | ||
| func (kc *KubeCtl) CreatePVC(pvc *corev1.PersistentVolumeClaim, namespace string) (*corev1.PersistentVolumeClaim, error) { | ||
| pvc, err := kc.Clientset.CoreV1().PersistentVolumeClaims(namespace).Create(pvc) |
There was a problem hiding this comment.
we can just use return kc.Clientset.CoreV1().PersistentVolumeClaims(namespace).Create(pvc).
The caller should check the error object.
hwchiu
reviewed
Jul 4, 2018
src/kubernetes/pods.go
Outdated
|
|
||
| //Create the pod by the pod object | ||
| func (kc *KubeCtl) CreatePod(pod *corev1.Pod, namespace string) (*corev1.Pod, error) { | ||
| pod, err := kc.Clientset.CoreV1().Pods(namespace).Create(pod) |
There was a problem hiding this comment.
return kc.Clientset.CoreV1().Pods(namespace).Create(pod)
src/kubernetes/services.go
Outdated
|
|
||
| //Create the service by the service object | ||
| func (kc *KubeCtl) CreateService(service *corev1.Service, namespace string) (*corev1.Service, error) { | ||
| service, err := kc.Clientset.CoreV1().Services(namespace).Create(service) |
There was a problem hiding this comment.
return kc.Clientset.CoreV1().Services(namespace).Create(service)
Codecov Report
@@ Coverage Diff @@
## develop #58 +/- ##
===========================================
+ Coverage 80.4% 81.08% +0.67%
===========================================
Files 20 23 +3
Lines 592 645 +53
===========================================
+ Hits 476 523 +47
- Misses 85 89 +4
- Partials 31 33 +2
Continue to review full report at Codecov.
|
John-Lin
approved these changes
Jul 4, 2018
chenyunchen
force-pushed
the
alex/addk8sfunction
branch
from
29c7384 to
04095f7
Compare
John-Lin
approved these changes
Jul 4, 2018
John-Lin
added a commit
that referenced
this pull request
Jul 25, 2018
VX-149 VX-150 Add k8s pod, service, pvc: get list create delete function Former-commit-id: 2e93f942b209e675723145e557b7ffb0bc8994d4 [formerly e206b23] Former-commit-id: 77129bca7098229b4145cc2be5b9b3fdddea2d8d
John-Lin
added a commit
that referenced
this pull request
Jul 25, 2018
VX-149 VX-150 Add k8s pod, service, pvc: get list create delete function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.