DEV VX-142: Node metrics handler #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchiu
approved these changes
Jul 4, 2018
| @@ -0,0 +1,41 @@ | |||
| package entity | |||
|
|
|||
| type NICNetworkTrafficMetrics struct { | |||
John-Lin
suggested changes
Jul 4, 2018
src/server/handler_prometheus.go
Outdated
| @@ -17,15 +19,12 @@ func queryMetrics(ctx *web.Context) { | |||
|
|
|||
| query := query.New(req.Request.URL.Query()) | |||
|
|
|||
| query_str := "" | |||
| expression := "" | |||
There was a problem hiding this comment.
how about using var expression string?
src/server/handler_node_metrics.go
Outdated
| func listNodeMetricsHandler(ctx *web.Context) { | ||
| sp, req, resp := ctx.ServiceProvider, ctx.Request, ctx.Response | ||
|
|
||
| result, err := queryFromPrometheus(sp, "sum by (node)(kube_node_info)") |
There was a problem hiding this comment.
should handle error. rignt?
src/server/handler_node_metrics.go
Outdated
| node.Info.Labels = map[string]string{} | ||
| node.NICs = map[string]entity.NICMetrics{} | ||
|
|
||
| results, _ := queryFromPrometheus(sp, `{__name__=~"kube_node_info|kube_node_created|node_network_interface|kube_node_labels|kube_node_status_allocatable_cpu_cores|kube_node_status_allocatable_memory_bytes|kube_node_status_capacity_cpu_cores|kube_node_status_capacity_memory_bytes|",node=~"`+id+`"}`) |
There was a problem hiding this comment.
should handle error. rignt?
src/server/handler_node_metrics.go
Outdated
| } | ||
| } | ||
|
|
||
| results, _ = queryFromPrometheus(sp, `sum by(__name__, resource) ({__name__=~"kube_pod_container_resource_limits|kube_pod_container_resource_requests",node=~"`+id+`"})`) |
There was a problem hiding this comment.
should handle error. rignt?
src/server/handler_node_metrics.go
Outdated
| } | ||
| } | ||
|
|
||
| results, _ = queryFromPrometheus(sp, `{__name__=~"node_network_interface|node_network_receive_bytes_total|node_network_transmit_bytes_total|node_network_receive_packets_total|node_network_transmit_packets_total",node=~"`+id+`"}`) |
There was a problem hiding this comment.
should handle error. rignt?
src/server/handler_prometheus.go
Outdated
|
|
||
| testTime := time.Now() | ||
| result, err := api.Query(context.Background(), query_str, testTime) | ||
| result, err := queryFromPrometheus(sp, expression) |
There was a problem hiding this comment.
should handle error. rignt?
Codecov Report
@@ Coverage Diff @@
## develop #59 +/- ##
============================================
- Coverage 80.84% 68.06% -12.78%
============================================
Files 23 29 +6
Lines 637 927 +290
============================================
+ Hits 515 631 +116
- Misses 88 255 +167
- Partials 34 41 +7
Continue to review full report at Codecov.
|
WakeupTsai
force-pushed
the
phstsai/VX-142
branch
from
1962d80 to
d79c18b
Compare
WakeupTsai
force-pushed
the
phstsai/VX-142
branch
from
f7c6748 to
3673e84
Compare
John-Lin
approved these changes
Jul 5, 2018
John-Lin
added a commit
that referenced
this pull request
Jul 25, 2018
DEV VX-142: Node metrics handler Former-commit-id: b9ce90d2974a0455d64b7c21a6aaf21287f5040f [formerly 95fc862] Former-commit-id: a881820fb01395748899590dde8f60eb5c50a654
John-Lin
added a commit
that referenced
this pull request
Jul 25, 2018
DEV VX-142: Node metrics handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.