-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the storage to support multiple type. #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hwchiu
commented
Jul 4, 2018
- Support multiple type of storage
- Rename from storageProvider to storage (contains files)
- Implement the FakeStorage for testing.
- The empty function of NFSStorage (Implement in another PR)
Codecov Report
@@ Coverage Diff @@
## develop #60 +/- ##
===========================================
- Coverage 80.84% 80.63% -0.22%
===========================================
Files 23 27 +4
Lines 637 692 +55
===========================================
+ Hits 515 558 +43
- Misses 88 99 +11
- Partials 34 35 +1
Continue to review full report at Codecov.
|
John-Lin
approved these changes
Jul 4, 2018
WakeupTsai
approved these changes
Jul 5, 2018
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
Refactor the storage to support multiple type. Former-commit-id: e2b3d4eba6df59dc1cdac3cfd86886c3a94606f4 [formerly eff9da7] Former-commit-id: 0909f1887eef2607b7a546134493f10327e141f6
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
Refactor the storage to support multiple type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.