Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the storage to support multiple type. #60

Merged
merged 7 commits into from
Jul 5, 2018
Merged

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jul 4, 2018

  1. Support multiple type of storage
  2. Rename from storageProvider to storage (contains files)
  3. Implement the FakeStorage for testing.
  4. The empty function of NFSStorage (Implement in another PR)

@codecov-io
Copy link

codecov-io commented Jul 4, 2018

Codecov Report

Merging #60 into develop will decrease coverage by 0.21%.
The diff coverage is 87.87%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #60      +/-   ##
===========================================
- Coverage    80.84%   80.63%   -0.22%     
===========================================
  Files           23       27       +4     
  Lines          637      692      +55     
===========================================
+ Hits           515      558      +43     
- Misses          88       99      +11     
- Partials        34       35       +1
Impacted Files Coverage Δ
src/storageprovider/nfs.go 0% <0%> (ø)
src/server/handler_volume.go 82.5% <100%> (ø) ⬆️
src/server/route.go 62.79% <100%> (ø) ⬆️
src/kubernetes/deployment.go 100% <100%> (ø)
src/storageprovider/storage.go 100% <100%> (ø)
src/storageprovider/fake.go 100% <100%> (ø)
src/server/handler_storage.go 83.67% <94.11%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fbbaa3...220f8d4. Read the comment docs.

@hwchiu hwchiu merged commit eff9da7 into develop Jul 5, 2018
@hwchiu hwchiu deleted the hwchiu/VX-120 branch July 5, 2018 06:15
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Refactor the storage to support multiple type.

Former-commit-id: e2b3d4eba6df59dc1cdac3cfd86886c3a94606f4 [formerly eff9da7]
Former-commit-id: 0909f1887eef2607b7a546134493f10327e141f6
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Refactor the storage to support multiple type.

Former-commit-id: e2b3d4eba6df59dc1cdac3cfd86886c3a94606f4 [formerly e2b3d4eba6df59dc1cdac3cfd86886c3a94606f4 [formerly eff9da7]]
Former-commit-id: 0909f1887eef2607b7a546134493f10327e141f6
Former-commit-id: 8311ae2
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Refactor the storage to support multiple type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants