Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flannel iface #61

Merged
merged 2 commits into from
Jul 4, 2018
Merged

flannel iface #61

merged 2 commits into from
Jul 4, 2018

Conversation

John-Lin
Copy link
Contributor

@John-Lin John-Lin commented Jul 4, 2018

No description provided.

@John-Lin John-Lin changed the title Johnlin/flannel iface flannel iface Jul 4, 2018
@codecov-io
Copy link

codecov-io commented Jul 4, 2018

Codecov Report

Merging #61 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #61   +/-   ##
========================================
  Coverage    80.84%   80.84%           
========================================
  Files           23       23           
  Lines          637      637           
========================================
  Hits           515      515           
  Misses          88       88           
  Partials        34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fbbaa3...fcd9006. Read the comment docs.

# Should give flannel the real network interface name
wget --quiet https://raw.githubusercontent.com/coreos/flannel/v0.9.1/Documentation/kube-flannel.yml -O /tmp/kube-flannel.yml
sed -i -- 's/"--kube-subnet-mgr"/"--kube-subnet-mgr", "--iface='"$NET_IF_NAME"'"/g' /tmp/kube-flannel.yml
cat /tmp/kube-flannel.yml | grep iface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove this?

@John-Lin John-Lin force-pushed the johnlin/flannel-iface branch from 037e2c5 to fcd9006 Compare July 4, 2018 14:32
@John-Lin
Copy link
Contributor Author

John-Lin commented Jul 4, 2018

done

@hwchiu hwchiu merged commit 043ed08 into develop Jul 4, 2018
@hwchiu hwchiu deleted the johnlin/flannel-iface branch July 4, 2018 16:33
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
flannel iface

Former-commit-id: 1eeac941a9d5ee75210cf5182af0a064f06fcabb [formerly 043ed08]
Former-commit-id: be7daaf4a871a41e8887081355f8baa33776ef3e
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
flannel iface

Former-commit-id: 1eeac941a9d5ee75210cf5182af0a064f06fcabb [formerly 1eeac941a9d5ee75210cf5182af0a064f06fcabb [formerly 043ed08]]
Former-commit-id: be7daaf4a871a41e8887081355f8baa33776ef3e
Former-commit-id: 964e2b8
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants