Add vlan tag option for port #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyunchen
force-pushed
the
alex/AddVlanTagOption
branch
4 times, most recently
from
cdae902 to
dd67fd4
Compare
John-Lin
approved these changes
Jul 5, 2018
chenyunchen
force-pushed
the
alex/AddVlanTagOption
branch
2 times, most recently
from
753beb9 to
f4272bc
Compare
|
Wait for protocobuf downgrade to 3.5.1 linkernetworks/network-controller#56 |
Codecov Report
@@ Coverage Diff @@
## develop #63 +/- ##
===========================================
+ Coverage 66.51% 66.78% +0.27%
===========================================
Files 28 28
Lines 854 867 +13
===========================================
+ Hits 568 579 +11
- Misses 250 251 +1
- Partials 36 37 +1
Continue to review full report at Codecov.
|
John-Lin
force-pushed
the
alex/AddVlanTagOption
branch
2 times, most recently
from
98e7d46 to
3d420ec
Compare
John-Lin
force-pushed
the
alex/AddVlanTagOption
branch
from
3d420ec to
a933218
Compare
John-Lin
approved these changes
Jul 6, 2018
John-Lin
added a commit
that referenced
this pull request
Jul 25, 2018
Add vlan tag option for port Former-commit-id: 95e0847c6397ee185db5507e1d2dc4234daa31a1 [formerly f586a31] Former-commit-id: a72496ff8b36c101b2432be1e8e9b88ea762d267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.