Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change entity.network type to pointer #64

Merged
merged 3 commits into from
Jul 6, 2018
Merged

change entity.network type to pointer #64

merged 3 commits into from
Jul 6, 2018

Conversation

John-Lin
Copy link
Contributor

@John-Lin John-Lin commented Jul 5, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 5, 2018 •
edited
Loading

Codecov Report

Merging #64 into develop will increase coverage by 0.46%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #64      +/-   ##
===========================================
+ Coverage    66.51%   66.97%   +0.46%     
===========================================
  Files           28       28              
  Lines          854      860       +6     
===========================================
+ Hits           568      576       +8     
+ Misses         250      249       -1     
+ Partials        36       35       -1
Impacted Files Coverage Δ
src/networkprovider/network.go 100% <ø> (ø) ⬆️
src/networkprovider/fake.go 100% <100%> (ø) ⬆️
src/server/handler_network.go 83.78% <100%> (ø) ⬆️
src/networkprovider/ovs.go 75.86% <100%> (ø) ⬆️
src/server/handler_prometheus.go 91.17% <0%> (+9.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95fc862...7ec730c. Read the comment docs.

@John-Lin John-Lin requested a review from hwchiu July 5, 2018 10:33
hwchiu
hwchiu approved these changes Jul 6, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwchiu hwchiu merged commit 78187da into develop Jul 6, 2018
@John-Lin John-Lin deleted the johnlin/fix-netowrk-type branch July 6, 2018 06:00
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #64 from linkernetworks/johnlin/fix-netowrk-type
a95b967 
change entity.network type to pointer

Former-commit-id: c01a148d90007b8c6aa56557e57070f0842258e7 [formerly 78187da]
Former-commit-id: 4ae0f7a39c97ccfa5d26780af501b2783aa1e96c
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #64 from linkernetworks/johnlin/fix-netowrk-type
a1ffad9 
change entity.network type to pointer

Former-commit-id: c01a148d90007b8c6aa56557e57070f0842258e7 [formerly c01a148d90007b8c6aa56557e57070f0842258e7 [formerly 78187da]]
Former-commit-id: 4ae0f7a39c97ccfa5d26780af501b2783aa1e96c
Former-commit-id: a95b967
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #64 from linkernetworks/johnlin/fix-netowrk-type
f128627 
change entity.network type to pointer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@John-Lin @codecov-io @hwchiu