Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create/Delete the storageClass when we create/delete the storage #66

Merged
merged 4 commits into from
Jul 6, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jul 6, 2018

Implement the NFS-Provisioner function, we will create the deployment and storageClass now.

@hwchiu hwchiu added the Feature Features label Jul 6, 2018
@codecov-io
Copy link

codecov-io commented Jul 6, 2018

Codecov Report

Merging #66 into develop will increase coverage by 0.24%.
The diff coverage is 84%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #66      +/-   ##
===========================================
+ Coverage     69.7%   69.95%   +0.24%     
===========================================
  Files           28       29       +1     
  Lines          931      952      +21     
===========================================
+ Hits           649      666      +17     
- Misses         245      247       +2     
- Partials        37       39       +2
Impacted Files Coverage Δ
src/kubernetes/storageclass.go 100% <100%> (ø)
src/storageprovider/nfs.go 95.18% <78.94%> (-4.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f307fb...7945b09. Read the comment docs.

@hwchiu hwchiu merged commit 158cdf7 into develop Jul 6, 2018
@hwchiu hwchiu deleted the hwchiu/VX-152 branch July 6, 2018 16:56
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Create/Delete the storageClass when we create/delete the storage

Former-commit-id: 7761297c7752d44f8ff3df66f96642b43d8b9b9d [formerly 158cdf7]
Former-commit-id: a52ab59e733d5540e1cb77786f46846ef22c1685
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Create/Delete the storageClass when we create/delete the storage

Former-commit-id: 7761297c7752d44f8ff3df66f96642b43d8b9b9d [formerly 7761297c7752d44f8ff3df66f96642b43d8b9b9d [formerly 158cdf7]]
Former-commit-id: a52ab59e733d5540e1cb77786f46846ef22c1685
Former-commit-id: 5f08d31
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Create/Delete the storageClass when we create/delete the storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants