Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support ovs/dpdk type #67

Merged
merged 4 commits into from
Jul 9, 2018
Merged

support ovs/dpdk type #67

merged 4 commits into from
Jul 9, 2018

Conversation

John-Lin
Copy link
Contributor

@John-Lin John-Lin commented Jul 6, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 6, 2018 •
edited
Loading

Codecov Report

Merging #67 into develop will decrease coverage by 7.88%.
The diff coverage is 45.31%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #67      +/-   ##
===========================================
- Coverage    69.95%   62.07%   -7.89%     
===========================================
  Files           29       36       +7     
  Lines          952     1263     +311     
===========================================
+ Hits           666      784     +118     
- Misses         247      429     +182     
- Partials        39       50      +11
Impacted Files Coverage Δ
src/networkprovider/network.go 100% <100%> (ø) ⬆️
src/networkcontroller/network_controller.go 43.11% <11.47%> (-40.22%) ⬇️
src/networkprovider/ovs_netdev.go 75% <75%> (ø)
src/server/route.go 53.7% <0%> (-10.75%) ⬇️
src/server/handler_metrics_controller.go 0% <0%> (ø)
src/volume/volume.go 100% <0%> (ø)
src/server/handler_metrics_container.go 0% <0%> (ø)
src/server/handler_metrics_pod.go 0% <0%> (ø)
src/server/handler_metrics_service.go 0% <0%> (ø)
src/server/handler_metrics_node.go 0% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 158cdf7...97701ce. Read the comment docs.

hwchiu
hwchiu approved these changes Jul 6, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@John-Lin John-Lin force-pushed the johnlin/ovs-dpdk branch from ec0d274 to 8e9768d Compare July 6, 2018 08:52
@John-Lin
Copy link
Contributor Author

John-Lin commented Jul 6, 2018

還不能merged 還有測試最後會squash

@John-Lin John-Lin added the WIP label Jul 6, 2018
@John-Lin John-Lin force-pushed the johnlin/ovs-dpdk branch 2 times, most recently from 9f43e25 to 44f7fd5 Compare July 6, 2018 17:59
@John-Lin John-Lin force-pushed the johnlin/ovs-dpdk branch from 97701ce to acc01e4 Compare July 9, 2018 06:22
@John-Lin John-Lin removed the WIP label Jul 9, 2018
@John-Lin
Copy link
Contributor Author

John-Lin commented Jul 9, 2018

@hwchiu ready to merge

@John-Lin John-Lin merged commit bd8533d into develop Jul 9, 2018
@hwchiu hwchiu deleted the johnlin/ovs-dpdk branch July 9, 2018 07:12
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #67 from linkernetworks/johnlin/ovs-dpdk
b33954a 
support ovs/dpdk type

Former-commit-id: 8f4bad95cf05fb8acd4e500d770e5a45b6d33a58 [formerly bd8533d]
Former-commit-id: 0b6c4117652af17169c8bf41718d4b0e80fa0e0f
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #67 from linkernetworks/johnlin/ovs-dpdk
82cf36a 
support ovs/dpdk type

Former-commit-id: 8f4bad95cf05fb8acd4e500d770e5a45b6d33a58 [formerly 8f4bad95cf05fb8acd4e500d770e5a45b6d33a58 [formerly bd8533d]]
Former-commit-id: 0b6c4117652af17169c8bf41718d4b0e80fa0e0f
Former-commit-id: b33954a
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #67 from linkernetworks/johnlin/ovs-dpdk
184a32e 
support ovs/dpdk type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@John-Lin @codecov-io @hwchiu