Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the namespace in the kubectl object #68

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Use the namespace in the kubectl object #68

merged 1 commit into from
Jul 6, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jul 6, 2018

Use the namespace in the kuberctl object, we don't need to pass the namespace into each function.

@hwchiu hwchiu requested review from John-Lin and chenyunchen July 6, 2018 07:27
@hwchiu hwchiu added the bug Something isn't working label Jul 6, 2018
@codecov-io
Copy link

codecov-io commented Jul 6, 2018 •
edited
Loading

Codecov Report

Merging #68 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop     #68   +/-   ##
=======================================
  Coverage     69.7%   69.7%           
=======================================
  Files           28      28           
  Lines          931     931           
=======================================
  Hits           649     649           
  Misses         245     245           
  Partials        37      37
Impacted Files Coverage Δ
src/kubernetes/pvc.go 86.66% <100%> (ø) ⬆️
src/kubernetes/pods.go 86.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea5afb5...16f9838. Read the comment docs.

@hwchiu hwchiu merged commit 1f307fb into develop Jul 6, 2018
@hwchiu hwchiu deleted the hwchiu/remove-unused-nanespace branch July 6, 2018 07:51
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #68 from linkernetworks/hwchiu/remove-unused-nanes…
c655b02 
…pace

Use the namespace in the kubectl object

Former-commit-id: e0d7717e0c8005ccaff7b6ac1b06b23b705369fc [formerly 1f307fb]
Former-commit-id: acca846e17998659486db81e8fb99e71fdd2919b
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #68 from linkernetworks/hwchiu/remove-unused-nanes…
a522f31 
…pace

Use the namespace in the kubectl object

Former-commit-id: e0d7717e0c8005ccaff7b6ac1b06b23b705369fc [formerly e0d7717e0c8005ccaff7b6ac1b06b23b705369fc [formerly 1f307fb]]
Former-commit-id: acca846e17998659486db81e8fb99e71fdd2919b
Former-commit-id: c655b02
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #68 from linkernetworks/hwchiu/remove-unused-nanes…
21d3569 
…pace

Use the namespace in the kubectl object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Lin John-Lin John-Lin approved these changes

@chenyunchen chenyunchen chenyunchen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hwchiu @codecov-io @John-Lin @chenyunchen