Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vim setting #69

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Add vim setting #69

merged 1 commit into from
Jul 6, 2018

Conversation

chenyunchen
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 6, 2018 •
edited
Loading

Codecov Report

Merging #69 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop     #69   +/-   ##
=======================================
  Coverage     69.7%   69.7%           
=======================================
  Files           28      28           
  Lines          931     931           
=======================================
  Hits           649     649           
  Misses         245     245           
  Partials        37      37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f307fb...b089baa. Read the comment docs.

@chenyunchen chenyunchen force-pushed the alex/AddVimSetting branch from 93362df to d623b86 Compare July 6, 2018 08:44
@chenyunchen chenyunchen force-pushed the alex/AddVimSetting branch from d623b86 to b089baa Compare July 6, 2018 09:33
hwchiu
hwchiu approved these changes Jul 6, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@John-Lin John-Lin merged commit d7e2263 into develop Jul 6, 2018
@hwchiu hwchiu deleted the alex/AddVimSetting branch July 9, 2018 02:35
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #69 from linkernetworks/alex/AddVimSetting
b22874c 
Add vim setting

Former-commit-id: 691cf2c3093b8d2b0f463948660e1e8baf39d78c [formerly d7e2263]
Former-commit-id: 6416a0eef21f1dc1d0eb9ab892ab18b750345994
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #69 from linkernetworks/alex/AddVimSetting
68579aa 
Add vim setting

Former-commit-id: 691cf2c3093b8d2b0f463948660e1e8baf39d78c [formerly 691cf2c3093b8d2b0f463948660e1e8baf39d78c [formerly d7e2263]]
Former-commit-id: 6416a0eef21f1dc1d0eb9ab892ab18b750345994
Former-commit-id: b22874c
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #69 from linkernetworks/alex/AddVimSetting
1aea6e7 
Add vim setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@John-Lin John-Lin John-Lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenyunchen @codecov-io @hwchiu @John-Lin