Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the create/delete for volume(pvc) via restful API #71

Merged
merged 5 commits into from
Jul 8, 2018
Merged

Support the create/delete for volume(pvc) via restful API #71

merged 5 commits into from
Jul 8, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jul 6, 2018

  • Create the Volume(PVC) based on the storage(StorageClass) we created before.

@hwchiu hwchiu added the Feature Features label Jul 6, 2018
@codecov-io
Copy link

codecov-io commented Jul 6, 2018 •
edited
Loading

Codecov Report

Merging #71 into develop will increase coverage by 0.71%.
The diff coverage is 91.83%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #71      +/-   ##
===========================================
+ Coverage    69.95%   70.67%   +0.71%     
===========================================
  Files           29       30       +1     
  Lines          952      989      +37     
===========================================
+ Hits           666      699      +33     
- Misses         247      252       +5     
+ Partials        39       38       -1
Impacted Files Coverage Δ
src/volume/volume.go 100% <100%> (ø)
src/server/handler_volume.go 78.57% <75%> (-3.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 158cdf7...5545155. Read the comment docs.

@hwchiu hwchiu requested review from John-Lin and chenyunchen July 6, 2018 17:22
@hwchiu hwchiu merged commit 006a9e8 into develop Jul 8, 2018
@hwchiu hwchiu deleted the hwchiu/VX-105 branch July 9, 2018 02:35
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #71 from linkernetworks/hwchiu/VX-105
cac2b2b 
Support the create/delete for volume(pvc) via restful API

Former-commit-id: 83ca49cd0998a60d943dda80108f1b096cfdefcf [formerly 006a9e8]
Former-commit-id: c1d7c36c6fe6e41c235cff10c435af42dff755b1
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #71 from linkernetworks/hwchiu/VX-105
d1bf0bb 
Support the create/delete for volume(pvc) via restful API

Former-commit-id: 83ca49cd0998a60d943dda80108f1b096cfdefcf [formerly 83ca49cd0998a60d943dda80108f1b096cfdefcf [formerly 006a9e8]]
Former-commit-id: c1d7c36c6fe6e41c235cff10c435af42dff755b1
Former-commit-id: cac2b2b
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #71 from linkernetworks/hwchiu/VX-105
4f0daac 
Support the create/delete for volume(pvc) via restful API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Lin John-Lin John-Lin approved these changes

@chenyunchen chenyunchen chenyunchen approved these changes

Assignees
No one assigned
Labels
Feature Features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hwchiu @codecov-io @John-Lin @chenyunchen