Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the volume before deleting the storage #74

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Check the volume before deleting the storage #74

merged 1 commit into from
Jul 10, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jul 9, 2018

We can't delete the storage if the storage is used by some volume

@hwchiu hwchiu added the enhancement New feature or request label Jul 9, 2018
@codecov-io
Copy link

Codecov Report

Merging #74 into develop will decrease coverage by 0.04%.
The diff coverage is 62.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #74      +/-   ##
===========================================
- Coverage    68.36%   68.31%   -0.05%     
===========================================
  Files           34       34              
  Lines         1062     1070       +8     
===========================================
+ Hits           726      731       +5     
- Misses         289      290       +1     
- Partials        47       49       +2
Impacted Files Coverage Δ
src/storageprovider/nfs.go 92.3% <62.5%> (-2.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f1877...f3459ff. Read the comment docs.

@hwchiu hwchiu merged commit 92d1323 into develop Jul 10, 2018
@hwchiu hwchiu deleted the hwchiu/VX-154 branch July 10, 2018 06:51
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #74 from linkernetworks/hwchiu/VX-154
88cb75f 
Check the volume before deleting the storage

Former-commit-id: 9b073fc36c5e6fda4dd79a0761cfcb7eb1a0ebb6 [formerly 92d1323]
Former-commit-id: 5ea79fa75eb3d0bb64339b4023829e68cd3cf875
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #74 from linkernetworks/hwchiu/VX-154
14f59a6 
Check the volume before deleting the storage

Former-commit-id: 9b073fc36c5e6fda4dd79a0761cfcb7eb1a0ebb6 [formerly 9b073fc36c5e6fda4dd79a0761cfcb7eb1a0ebb6 [formerly 92d1323]]
Former-commit-id: 5ea79fa75eb3d0bb64339b4023829e68cd3cf875
Former-commit-id: 88cb75f
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #74 from linkernetworks/hwchiu/VX-154
65ed39a 
Check the volume before deleting the storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwchiu @codecov-io