Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pod handler #76

Merged
merged 2 commits into from
Jul 10, 2018
Merged

Add pod handler #76

merged 2 commits into from
Jul 10, 2018

Conversation

chenyunchen
Copy link
Contributor

No description provided.

@chenyunchen chenyunchen requested review from John-Lin and hwchiu July 10, 2018 02:33
John-Lin
John-Lin suggested changes Jul 10, 2018
View reviewed changes
src/entity/pod.go Outdated
)

const (
PodCollectionName string = "pod"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pods

@John-Lin John-Lin requested review from WakeupTsai and sufuf3 July 10, 2018 02:41
@codecov-io
Copy link

codecov-io commented Jul 10, 2018 •
edited
Loading

Codecov Report

Merging #76 into develop will increase coverage by 1.12%.
The diff coverage is 79.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #76      +/-   ##
===========================================
+ Coverage    68.36%   69.48%   +1.12%     
===========================================
  Files           34       36       +2     
  Lines         1062     1170     +108     
===========================================
+ Hits           726      813      +87     
- Misses         289      304      +15     
- Partials        47       53       +6
Impacted Files Coverage Δ
src/server/handler_volume.go 79.51% <ø> (+0.94%) ⬆️
src/pod/pod.go 100% <100%> (ø)
src/server/handler_pod.go 74.39% <74.39%> (ø)
src/server/route.go 48.33% <87.5%> (+6.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f1877...e9cc971. Read the comment docs.

hwchiu
hwchiu approved these changes Jul 10, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwchiu hwchiu merged commit dbcd904 into develop Jul 10, 2018
@hwchiu hwchiu deleted the alex/addPodHandler branch July 10, 2018 06:51
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #76 from linkernetworks/alex/addPodHandler
5496eeb 
Add pod handler

Former-commit-id: 631244849d777f700c60e6efe21b802093008df7 [formerly dbcd904]
Former-commit-id: c106704cef622ce4cda6ca099d1b335ad3a42518
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #76 from linkernetworks/alex/addPodHandler
70df268 
Add pod handler

Former-commit-id: 631244849d777f700c60e6efe21b802093008df7 [formerly 631244849d777f700c60e6efe21b802093008df7 [formerly dbcd904]]
Former-commit-id: c106704cef622ce4cda6ca099d1b335ad3a42518
Former-commit-id: 5496eeb
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #76 from linkernetworks/alex/addPodHandler
3f99502 
Add pod handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@John-Lin John-Lin John-Lin approved these changes

@WakeupTsai WakeupTsai WakeupTsai approved these changes

@sufuf3 sufuf3 Awaiting requested review from sufuf3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chenyunchen @codecov-io @hwchiu @John-Lin @WakeupTsai