network entity refactoring #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
John-Lin
force-pushed
the
johnlin/network-entity
branch
from
6fd94d4 to
7120a63
Compare
Codecov Report
@@ Coverage Diff @@
## develop #77 +/- ##
===========================================
+ Coverage 69.68% 71.05% +1.36%
===========================================
Files 32 32
Lines 1260 1247 -13
===========================================
+ Hits 878 886 +8
+ Misses 324 307 -17
+ Partials 58 54 -4
Continue to review full report at Codecov.
|
zyfdegh
approved these changes
Jul 12, 2018
| PhysicalPorts: []entity.PhysicalPort{eth1}, | ||
| Type: entity.OVSKernelspaceNetworkType, | ||
| Name: tName, | ||
| VLANTags: []int32{0, 2048, 4095}, |
There was a problem hiding this comment.
Need double check: you're using 4095, not 4096?
There was a problem hiding this comment.
yes! 4096 is a invalid number
src/networkprovider/fake.go
Outdated
| @@ -7,27 +7,37 @@ import ( | |||
| "github.com/linkernetworks/vortex/src/serviceprovider" | |||
| ) | |||
|
|
|||
| type FakeNetworkProvider struct { | |||
| entity.FakeNetwork | |||
| type fakenetworkprovider struct { | |||
src/networkprovider/ovs_netdev.go
Outdated
| @@ -10,107 +10,98 @@ import ( | |||
| "gopkg.in/mgo.v2/bson" | |||
| ) | |||
|
|
|||
| type OVSUserspaceNetworkProvider struct { | |||
| entity.OVSUserspaceNetwork | |||
| type userspacenetworkprovider struct { | |||
src/server/handler_network_test.go
Outdated
| }) | ||
| } | ||
| } | ||
| // func (suite *NetworkTestSuite) TestListNetwork() { |
John-Lin
force-pushed
the
johnlin/network-entity
branch
2 times, most recently
from
2329b39 to
5544650
Compare
John-Lin
force-pushed
the
johnlin/network-entity
branch
from
5544650 to
1f5b746
Compare
John-Lin
force-pushed
the
johnlin/network-entity
branch
from
9d4670b to
3f0b324
Compare
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
network entity refactoring Former-commit-id: 952a28b6da2a7f5d164ba4e2120155091091209f [formerly ed661fd] Former-commit-id: 1f44b3288dca7441cee1f4d9cdb9a15894219a66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Test cases have to modify against current changes