Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use kubectl namespace for service #78

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Use kubectl namespace for service #78

merged 1 commit into from
Jul 10, 2018

Conversation

chenyunchen
Copy link
Contributor

No description provided.

@chenyunchen chenyunchen changed the title Remove namespace from service Use kubectl namespace from service Jul 10, 2018
@chenyunchen chenyunchen changed the title Use kubectl namespace from service Use kubectl namespace for service Jul 10, 2018
@codecov-io
Copy link

codecov-io commented Jul 10, 2018 •
edited
Loading

Codecov Report

Merging #78 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #78   +/-   ##
========================================
  Coverage    68.36%   68.36%           
========================================
  Files           34       34           
  Lines         1062     1062           
========================================
  Hits           726      726           
  Misses         289      289           
  Partials        47       47
Impacted Files Coverage Δ
src/kubernetes/services.go 86.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f1877...df8f803. Read the comment docs.

@John-Lin John-Lin merged commit e28bf30 into develop Jul 10, 2018
@hwchiu hwchiu deleted the alex/removeServiceNamespace branch July 10, 2018 06:51
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #78 from linkernetworks/alex/removeServiceNamespace
fa0a5dc 
Use kubectl namespace for service

Former-commit-id: d10e222420c9ff55325c40e79e269571ccf6f420 [formerly e28bf30]
Former-commit-id: 7d0f25843b8485a5700c9c8e930e6480b5b1022e
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #78 from linkernetworks/alex/removeServiceNamespace
8da8290 
Use kubectl namespace for service

Former-commit-id: d10e222420c9ff55325c40e79e269571ccf6f420 [formerly d10e222420c9ff55325c40e79e269571ccf6f420 [formerly e28bf30]]
Former-commit-id: 7d0f25843b8485a5700c9c8e930e6480b5b1022e
Former-commit-id: fa0a5dc
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #78 from linkernetworks/alex/removeServiceNamespace
b00f27b 
Use kubectl namespace for service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Lin John-Lin John-Lin approved these changes

@WakeupTsai WakeupTsai WakeupTsai approved these changes

@hwchiu hwchiu Awaiting requested review from hwchiu

@sufuf3 sufuf3 Awaiting requested review from sufuf3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenyunchen @codecov-io @John-Lin @WakeupTsai