Add dockerfile build in Makefile #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchiu
suggested changes
Jun 19, 2018
Makefile
Outdated
|
|
||
| ## dockerfiles/ ######################################## | ||
| docker.build: | ||
| docker build -t="sdnvortex/cv-server:latest" ./dockerfiles/ |
There was a problem hiding this comment.
use the dockerfiles/dockerfile as the dependency of target docker.build
Please rebase master and check the build won't fail.
By the way, use the variable for tag, such as
--tag $(DOCKER_REGISTRY)/$(PROJECT):$(IMAGE_TAG) \
--file $< .
sufuf3
force-pushed
the
sufuf3/make-docker
branch
from
6e3f241 to
cb7ca00
Compare
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
======================================
Coverage 46.9% 46.9%
======================================
Files 11 11
Lines 307 307
======================================
Hits 144 144
Misses 152 152
Partials 11 11Continue to review full report at Codecov.
|
hwchiu
suggested changes
Jun 19, 2018
hwchiu
reviewed
Jun 19, 2018
Makefile
Outdated
| ## For docker | ||
| DOCKER_REGISTRY = sdnvortex | ||
| IMAGE_TAG = latest | ||
| PROJECT = cv-server |
sufuf3
force-pushed
the
sufuf3/make-docker
branch
from
cb7ca00 to
f9cd5e0
Compare
yarencheng
approved these changes
Jun 19, 2018
yarencheng
reviewed
Jun 19, 2018
dockerfiles/Dockerfile
Outdated
|
|
||
| ENV CGO_ENABLED 0 | ||
| ENV GOOS linux | ||
| ENV TIMEZONE "Asia/Shanghai" | ||
| ARG BUILD_MODE=release | ||
| ARG BRAND=aurora | ||
| ARG BRAND=vortex |
There was a problem hiding this comment.
@hwchiu BRAND should be removed not changed?
There was a problem hiding this comment.
This BRAND is for L24.
There was a problem hiding this comment.
We don't need the BRAND here, that's for our previous project.
There was a problem hiding this comment.
Also modify the L24 to remove the BRAND, Thanks
sufuf3
force-pushed
the
sufuf3/make-docker
branch
from
f9cd5e0 to
51fa044
Compare
|
I fixed it. |
- Add docker build - Fix typo from vortext to vortex
sufuf3
force-pushed
the
sufuf3/make-docker
branch
from
51fa044 to
4791ad6
Compare
hwchiu
approved these changes
Jun 19, 2018
dockerfiles/Dockerfile
Outdated
|
|
||
| ENV CGO_ENABLED 0 | ||
| ENV GOOS linux | ||
| ENV TIMEZONE "Asia/Shanghai" | ||
| ARG BUILD_MODE=release | ||
| ARG BRAND=aurora | ||
| ARG BRAND=vortex |
There was a problem hiding this comment.
Also modify the L24 to remove the BRAND, Thanks
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
DEV: Phstsai/add kube state metrics Approved-by: Yo-An Lin <[email protected]> Approved-by: Hung-Wei Chiu <[email protected]> Former-commit-id: c2568673160410ee5c27de9dd6ec1556d07159e7 [formerly da59bf3] Former-commit-id: 6c81e35fc5be5c022fc666d558a549b42c32175e
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
Add dockerfile build in Makefile Former-commit-id: abbe5cc086466197393150e28bea8d0c218a2427 [formerly 1ef925f] Former-commit-id: 1f3ce17a40dc17fbf3a06e4b62194ac695a10813
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
DEV: Phstsai/add kube state metrics Approved-by: Yo-An Lin <[email protected]> Approved-by: Hung-Wei Chiu <[email protected]> Former-commit-id: c2568673160410ee5c27de9dd6ec1556d07159e7 [formerly c2568673160410ee5c27de9dd6ec1556d07159e7 [formerly da59bf3]] Former-commit-id: 6c81e35fc5be5c022fc666d558a549b42c32175e Former-commit-id: d37dd00
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
DEV: Phstsai/add kube state metrics Approved-by: Yo-An Lin <[email protected]> Approved-by: Hung-Wei Chiu <[email protected]>
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
Add dockerfile build in Makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.