Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flat the storage entity and change the meta name of volume. #80

Merged
merged 3 commits into from
Jul 11, 2018
Merged

Flat the storage entity and change the meta name of volume. #80

merged 3 commits into from
Jul 11, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jul 10, 2018

  1. 將 NFS 的結構攤平到 Storage 那邊，前端那邊比較喜歡這樣處理 (我們就保證只提供 NFS 的功能，不然攤平後很難擴展參數)
  2. 將 Volume 設定 Metaname的部分改寫，不用存入 DB, Volume物件自己提供function去計算

@hwchiu hwchiu requested a review from chenyunchen July 10, 2018 07:41
@codecov-io
Copy link

Codecov Report

Merging #80 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #80      +/-   ##
===========================================
+ Coverage    68.05%   68.07%   +0.02%     
===========================================
  Files           32       32              
  Lines         1202     1203       +1     
===========================================
+ Hits           818      819       +1     
  Misses         329      329              
  Partials        55       55
Impacted Files Coverage Δ
src/server/handler_volume.go 79.26% <ø> (-0.25%) ⬇️
src/storageprovider/nfs.go 92.3% <100%> (ø) ⬆️
src/volume/volume.go 100% <100%> (ø) ⬆️
src/storageprovider/storage.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f8c14...28127bc. Read the comment docs.

@hwchiu hwchiu merged commit 89308e0 into develop Jul 11, 2018
@hwchiu hwchiu deleted the hwchiu/VX-158 branch July 11, 2018 09:16
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #80 from linkernetworks/hwchiu/VX-158
f214af0 
Flat the storage entity and change the meta name of volume.

Former-commit-id: 16e8069190839641593528541d6c52f3e873c056 [formerly 89308e0]
Former-commit-id: 324d0b124528da2da137c5172b7ee28ac8248afe
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #80 from linkernetworks/hwchiu/VX-158
5480894 
Flat the storage entity and change the meta name of volume.

Former-commit-id: 16e8069190839641593528541d6c52f3e873c056 [formerly 16e8069190839641593528541d6c52f3e873c056 [formerly 89308e0]]
Former-commit-id: 324d0b124528da2da137c5172b7ee28ac8248afe
Former-commit-id: f214af0
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #80 from linkernetworks/hwchiu/VX-158
0e01f53 
Flat the storage entity and change the meta name of volume.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenyunchen chenyunchen chenyunchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hwchiu @codecov-io @chenyunchen