Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the volume mount for Pod #81

Merged
merged 3 commits into from
Jul 11, 2018
Merged

Support the volume mount for Pod #81

merged 3 commits into from
Jul 11, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jul 11, 2018

Now, We can attach the volumes we created before to each Pods.
All the containers in the Pod use the same volumeMounts.

@codecov-io
Copy link

codecov-io commented Jul 11, 2018

Codecov Report

Merging #81 into develop will increase coverage by 0.81%.
The diff coverage is 93.61%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #81      +/-   ##
===========================================
+ Coverage    68.05%   68.86%   +0.81%     
===========================================
  Files           32       32              
  Lines         1202     1243      +41     
===========================================
+ Hits           818      856      +38     
- Misses         329      330       +1     
- Partials        55       57       +2
Impacted Files Coverage Δ
src/server/handler_pod.go 75.29% <100%> (+0.9%) ⬆️
src/pod/pod.go 94.73% <93.18%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f8c14...9e55ea2. Read the comment docs.

@hwchiu hwchiu merged commit c335193 into develop Jul 11, 2018
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Support the volume mount for Pod

Former-commit-id: 25365b133459e6760294603374f9b2a34e33e421 [formerly c335193]
Former-commit-id: 6e7464589929be23071da506bee418afdf6a507d
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Support the volume mount for Pod

Former-commit-id: 25365b133459e6760294603374f9b2a34e33e421 [formerly 25365b133459e6760294603374f9b2a34e33e421 [formerly c335193]]
Former-commit-id: 6e7464589929be23071da506bee418afdf6a507d
Former-commit-id: 209da90
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Support the volume mount for Pod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants