Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Change the response status form BadRequest to InternalServerError #82

Merged
merged 1 commit into from
Jul 11, 2018
Merged

BUGFIX: Change the response status form BadRequest to InternalServerError #82

merged 1 commit into from
Jul 11, 2018

Conversation

WakeupTsai
Copy link
Contributor

Prometheus's API cannot give us the accurate error, so we only can know what problem we encounter by the error message.

@codecov-io
Copy link

Codecov Report

Merging #82 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #82   +/-   ##
========================================
  Coverage    68.05%   68.05%           
========================================
  Files           32       32           
  Lines         1202     1202           
========================================
  Hits           818      818           
  Misses         329      329           
  Partials        55       55
Impacted Files Coverage Δ
src/server/handler_prometheus.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f8c14...4fb20bf. Read the comment docs.

hwchiu
hwchiu approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwchiu hwchiu merged commit 869e51a into develop Jul 11, 2018
@hwchiu hwchiu deleted the phstsai/change-response-status branch July 11, 2018 08:32
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #82 from linkernetworks/phstsai/change-response-st…
c14aebd 
…atus

BUGFIX: Change the response status form BadRequest to InternalServerError
Former-commit-id: 5f3437e664682a4bcf6febd5de49857555c005e6 [formerly 869e51a]
Former-commit-id: 768701cc4b42861935777065450e6f6dd3f00eff
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #82 from linkernetworks/phstsai/change-response-st…
8930157 
…atus

BUGFIX: Change the response status form BadRequest to InternalServerError
Former-commit-id: 5f3437e664682a4bcf6febd5de49857555c005e6 [formerly 5f3437e664682a4bcf6febd5de49857555c005e6 [formerly 869e51a]]
Former-commit-id: 768701cc4b42861935777065450e6f6dd3f00eff
Former-commit-id: c14aebd
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #82 from linkernetworks/phstsai/change-response-st…
3e63121 
…atus

BUGFIX: Change the response status form BadRequest to InternalServerError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@chenyunchen chenyunchen chenyunchen approved these changes

@John-Lin John-Lin Awaiting requested review from John-Lin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WakeupTsai @codecov-io @hwchiu @chenyunchen