VX-72 VX-73 VX-74 Add pod get function & regex name check & api docs #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #84 +/- ##
==========================================
+ Coverage 68.86% 69.27% +0.4%
==========================================
Files 32 32
Lines 1243 1266 +23
==========================================
+ Hits 856 877 +21
- Misses 330 331 +1
- Partials 57 58 +1
Continue to review full report at Codecov.
|
chenyunchen
force-pushed
the
alex/fixPodGenerate
branch
from
5c964e9 to
4ee5ab0
Compare
chenyunchen
changed the title
hwchiu
reviewed
Jul 11, 2018
src/pod/pod.go
Outdated
| @@ -72,13 +78,20 @@ func CreatePod(sp *serviceprovider.Container, pod *entity.Pod) error { | |||
|
|
|||
| var containers []corev1.Container | |||
| for _, container := range pod.Containers { | |||
| if !checkName(container.Name) { | |||
There was a problem hiding this comment.
I think we can check the name in the CheckPodParameter function.
src/server/handler_pod.go
Outdated
| @@ -41,7 +41,7 @@ func createPod(ctx *web.Context) { | |||
| } | |||
|
|
|||
| if err := pod.CreatePod(sp, &p); err != nil { | |||
| response.InternalServerError(req.Request, resp.ResponseWriter, err) | |||
| response.BadRequest(req.Request, resp.ResponseWriter, err) | |||
There was a problem hiding this comment.
Keep the InternalServerError, we will check the parameter in the above function pod.CheckPodParameter
chenyunchen
force-pushed
the
alex/fixPodGenerate
branch
from
1499f15 to
8d36b66
Compare
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
VX-72 VX-73 VX-74 Add pod get function & regex name check & api docs Former-commit-id: 3fd24e7f162769ee586c1fe5c6bea656567c797a [formerly 88f7285] Former-commit-id: 840cc65e463b19bde9fc1472ce9914b97bea1a9d
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
VX-72 VX-73 VX-74 Add pod get function & regex name check & api docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.