Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Prometheus API document #86

Merged
merged 3 commits into from
Jul 12, 2018
Merged

DEV: Prometheus API document #86

merged 3 commits into from
Jul 12, 2018

Conversation

WakeupTsai
Copy link
Contributor

No description provided.

@WakeupTsai
fix typo
6fc22d5 
delete one line
@WakeupTsai WakeupTsai force-pushed the phstsai/api-document branch from 151be00 to 6fc22d5 Compare July 12, 2018 02:52
@codecov-io
Copy link

codecov-io commented Jul 12, 2018 •
edited
Loading

Codecov Report

Merging #86 into develop will increase coverage by 0.38%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #86      +/-   ##
===========================================
+ Coverage    69.29%   69.68%   +0.38%     
===========================================
  Files           32       32              
  Lines         1267     1260       -7     
===========================================
  Hits           878      878              
+ Misses         331      324       -7     
  Partials        58       58
Impacted Files Coverage Δ
src/server/handler_prometheus.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48bdfde...6fc22d5. Read the comment docs.

John-Lin
John-Lin approved these changes Jul 12, 2018
View reviewed changes
Copy link
Contributor

@John-Lin John-Lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR改動盡量單純一點。如果這個PR只有改 api docs 就不要改code了

hwchiu
hwchiu approved these changes Jul 12, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwchiu hwchiu merged commit 1eec4d1 into develop Jul 12, 2018
@hwchiu hwchiu deleted the phstsai/api-document branch July 12, 2018 03:24
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #86 from linkernetworks/phstsai/api-document
4d3a291 
DEV: Prometheus API document
Former-commit-id: b55d15652676a98f335cedb38757c0f56a8e7bba [formerly 1eec4d1]
Former-commit-id: d33bdad16ee992f3b84343d175d86d7a28ba9ff5
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #86 from linkernetworks/phstsai/api-document
f4335ba 
DEV: Prometheus API document
Former-commit-id: b55d15652676a98f335cedb38757c0f56a8e7bba [formerly b55d15652676a98f335cedb38757c0f56a8e7bba [formerly 1eec4d1]]
Former-commit-id: d33bdad16ee992f3b84343d175d86d7a28ba9ff5
Former-commit-id: 4d3a291
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #86 from linkernetworks/phstsai/api-document
7e110ad 
DEV: Prometheus API document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@John-Lin John-Lin John-Lin approved these changes

@chenyunchen chenyunchen Awaiting requested review from chenyunchen

@sufuf3 sufuf3 Awaiting requested review from sufuf3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WakeupTsai @codecov-io @hwchiu @John-Lin