VX-166 remove validate function #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchiu
suggested changes
Jul 13, 2018
src/server/handler_network_test.go
Outdated
| @@ -329,12 +329,6 @@ func (suite *NetworkTestSuite) TestListNetwork() { | |||
| err = json.Unmarshal(httpWriter.Body.Bytes(), &retNetworks) | |||
| suite.NoError(err) | |||
| suite.Equal(tc.expectSize, len(retNetworks)) | |||
| for i, v := range retNetworks { | |||
There was a problem hiding this comment.
Without those test, how did you make sure you get what you store ?
src/server/handler_network.go
Outdated
|
|
||
| networkProvider, err := np.GetNetworkProvider(&network) | ||
| if err != nil { | ||
| if err := entity.ValidateVLANTags(network.VLANTags); err != nil { |
There was a problem hiding this comment.
我認為我們不應該再 restful handler 這邊有太多網路邏輯的檢查，這部分應該都是後端實作去檢查。
這種情況下，只要未來後端網路有任何更動，你都需要更改 restful handler, 我們應該只要專注於後端網路本身的實作修改就好。
Codecov Report
@@ Coverage Diff @@
## develop #89 +/- ##
===========================================
- Coverage 71.05% 70.41% -0.64%
===========================================
Files 32 32
Lines 1247 1217 -30
===========================================
- Hits 886 857 -29
- Misses 307 308 +1
+ Partials 54 52 -2
Continue to review full report at Codecov.
|
…and type checking
John-Lin
force-pushed
the
johnlin/remove-validate
branch
from
a1c1f65 to
a13bece
Compare
chenyunchen
approved these changes
Jul 13, 2018
John-Lin
added a commit
that referenced
this pull request
Jul 25, 2018
VX-166 remove validate function Former-commit-id: dd91b313a1757e62b9f778e1ebe427c518297060 [formerly c2d1b1b] Former-commit-id: cf7af7d9931f360a38b6fe8129e8b46a88fd9a7d
John-Lin
added a commit
that referenced
this pull request
Jul 25, 2018
VX-166 remove validate function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.