Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network-controller & vortex server k8s yaml files #9

Merged
merged 2 commits into from
Jun 20, 2018

Conversation

sufuf3
Copy link
Contributor

@sufuf3 sufuf3 commented Jun 19, 2018

  • Add network-controller server k8s daemonset
  • Add cv-server k8s deployment & service

@codecov-io
Copy link

codecov-io commented Jun 19, 2018

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master      #9   +/-   ##
======================================
  Coverage    46.9%   46.9%           
======================================
  Files          11      11           
  Lines         307     307           
======================================
  Hits          144     144           
  Misses        152     152           
  Partials       11      11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345f29d...60f8168. Read the comment docs.

@sufuf3 sufuf3 force-pushed the sufuf3/add-k8syaml branch from da6f379 to 94e4379 Compare June 19, 2018 08:45
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the file from cv-server to vortex

apiVersion: apps/v1
kind: Deployment
metadata:
name: cv-server-deployment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should rename. we don't use cv-server

kind: Service
apiVersion: v1
metadata:
name: cv-server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should rename. we don't use cv-server

@sufuf3 sufuf3 changed the title Add network-controller server & cv-server k8s yaml files Add network-controller server & vortex k8s yaml files Jun 19, 2018
@sufuf3 sufuf3 force-pushed the sufuf3/add-k8syaml branch from 94e4379 to 7d44d79 Compare June 19, 2018 09:36
@sufuf3 sufuf3 requested review from hwchiu and John-Lin June 19, 2018 09:40
@sufuf3
Copy link
Contributor Author

sufuf3 commented Jun 19, 2018

I fixed it.

@hwchiu
Copy link
Contributor

hwchiu commented Jun 19, 2018

Thanks!!
Since we are in the vortex directory, we don't need the prefix name (vortex) for deployment and service.
Besides, please also add the ovs-sock in the tcp-server (also update that in network-controller repo)
Thanks.

@sufuf3 sufuf3 force-pushed the sufuf3/add-k8syaml branch from d008833 to 60f8168 Compare June 20, 2018 02:07
@sufuf3 sufuf3 changed the title Add network-controller server & vortex k8s yaml files Add network-controller & vortex server k8s yaml files Jun 20, 2018
@John-Lin John-Lin merged commit 3f81acc into master Jun 20, 2018
@John-Lin John-Lin deleted the sufuf3/add-k8syaml branch June 20, 2018 04:05
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
fix the bug of unit test

Approved-by: Hung-Wei Chiu <[email protected]>

Former-commit-id: 5e46850267938e5fa4b3689913d75795d4b0a998 [formerly 4dde091]
Former-commit-id: 9356ffff9f626c1239fdcb6a4357f28d68adbbf8
John-Lin added a commit that referenced this pull request Jul 25, 2018
Add network-controller & vortex server k8s yaml files

Former-commit-id: e768502e46424bb6303590f288eef6f58b51ef65 [formerly 3f81acc]
Former-commit-id: c538c226d476403042bfde1258281883cb18fd73
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
fix the bug of unit test

Approved-by: Hung-Wei Chiu <[email protected]>

Former-commit-id: 5e46850267938e5fa4b3689913d75795d4b0a998 [formerly 5e46850267938e5fa4b3689913d75795d4b0a998 [formerly 4dde091]]
Former-commit-id: 9356ffff9f626c1239fdcb6a4357f28d68adbbf8
Former-commit-id: 7222c1e
John-Lin added a commit that referenced this pull request Jul 25, 2018
Add network-controller & vortex server k8s yaml files

Former-commit-id: e768502e46424bb6303590f288eef6f58b51ef65 [formerly e768502e46424bb6303590f288eef6f58b51ef65 [formerly 3f81acc]]
Former-commit-id: c538c226d476403042bfde1258281883cb18fd73
Former-commit-id: fc2f434
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
fix the bug of unit test

Approved-by: Hung-Wei Chiu <[email protected]>
John-Lin added a commit that referenced this pull request Jul 25, 2018
Add network-controller & vortex server k8s yaml files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants