Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VX-171 generate bridge name #93

Merged
merged 3 commits into from
Jul 13, 2018
Merged

VX-171 generate bridge name #93

merged 3 commits into from
Jul 13, 2018

Conversation

John-Lin
Copy link
Contributor

No description provided.

@John-Lin John-Lin changed the title generate bridge name VX-171 generate bridge name Jul 13, 2018
@codecov-io
Copy link

codecov-io commented Jul 13, 2018 •
edited
Loading

Codecov Report

Merging #93 into develop will increase coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #93      +/-   ##
==========================================
+ Coverage    69.95%   70.2%   +0.24%     
==========================================
  Files           32      33       +1     
  Lines         1205    1215      +10     
==========================================
+ Hits           843     853      +10     
  Misses         309     309              
  Partials        53      53
Impacted Files Coverage Δ
src/server/handler_network.go 81.89% <100%> (+0.15%) ⬆️
src/networkprovider/network.go 100% <100%> (ø) ⬆️
src/utils/utils.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdcd83f...8f927a2. Read the comment docs.

WakeupTsai
WakeupTsai reviewed Jul 13, 2018
View reviewed changes
src/utils/utils_test.go Outdated
"github.com/stretchr/testify/assert"
)

func TestGenerateVethName(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function name should be TestSHA256String?

hwchiu
hwchiu approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hwchiu
hwchiu approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwchiu hwchiu merged commit ade8804 into develop Jul 13, 2018
@hwchiu hwchiu deleted the johnlin/gen-brName branch July 13, 2018 10:29
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #93 from linkernetworks/johnlin/gen-brName
1617a82 
VX-171 generate bridge name

Former-commit-id: 147019501bd8c5d46728e992d11ca986dc205927 [formerly ade8804]
Former-commit-id: 9a791865573718f22e42134fa9bd200adf3da64c
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #93 from linkernetworks/johnlin/gen-brName
4640d69 
VX-171 generate bridge name

Former-commit-id: 147019501bd8c5d46728e992d11ca986dc205927 [formerly 147019501bd8c5d46728e992d11ca986dc205927 [formerly ade8804]]
Former-commit-id: 9a791865573718f22e42134fa9bd200adf3da64c
Former-commit-id: 1617a82
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #93 from linkernetworks/johnlin/gen-brName
0516cb3 
VX-171 generate bridge name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WakeupTsai WakeupTsai WakeupTsai left review comments

@hwchiu hwchiu hwchiu approved these changes

@chenyunchen chenyunchen chenyunchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@John-Lin @codecov-io @hwchiu @chenyunchen @WakeupTsai