VX-172 Add prometheus testing #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WakeupTsai
reviewed
Jul 13, 2018
src/kubernetes/kubectl_test.go
Outdated
| assert.Equal(t, namespace, kubectl.Namespace) | ||
| assert.NotNil(t, kubectl) | ||
|
|
||
| kubectl.ChangeNamespace("test") |
WakeupTsai
approved these changes
Jul 13, 2018
John-Lin
suggested changes
Jul 13, 2018
src/kubernetes/kubectl.go
Outdated
| @@ -24,3 +24,7 @@ func New(clientset kubernetes.Interface, namespace string) *KubeCtl { | |||
| Namespace: namespace, | |||
| } | |||
| } | |||
|
|
|||
| func (kc *KubeCtl) ChangeNamespace(namespace string) { | |||
Codecov Report
@@ Coverage Diff @@
## develop #94 +/- ##
===========================================
- Coverage 69.95% 56.8% -13.16%
===========================================
Files 32 35 +3
Lines 1205 1741 +536
===========================================
+ Hits 843 989 +146
- Misses 309 685 +376
- Partials 53 67 +14
Continue to review full report at Codecov.
|
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
VX-172 Add prometheus testing Former-commit-id: 0780526b7e77a869574fa11e5eb614df91a8d61a [formerly 7ee8e63] Former-commit-id: 03671197e950a65ed4a7cec5d86a720f30fca5ab
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
VX-172 Add prometheus testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.