VX-175 valitate network entity before insert #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WakeupTsai
approved these changes
Jul 13, 2018
hwchiu
reviewed
Jul 13, 2018
src/entity/network.go
Outdated
| Type NetworkType `bson:"type" json:"type" validate:"required"` | ||
| IsDPDKPort bool `bson:"isDPDKPort" json:"isDPDKPort" validate:"required"` | ||
| Name string `bson:"name" json:"name" validate:"required"` | ||
| VLANTags []int32 `bson:"VLANTags" json:"VLANTags" validate:"required,dive,max=4095,min=0"` |
There was a problem hiding this comment.
我覺得 VlanTag 好像不是一定要?
有些應用他就沒有要vlan
There was a problem hiding this comment.
這邊應該是讓 entity 的欄位更加清楚，要給 VLANTags: [] 才算一個成功的 POST
There was a problem hiding this comment.
就是 VLANTags: [] 是表示沒有tags ，而缺少VLANTags欄位則是非法的entity。所以沒有給 VLANTags欄位的話就會被 server 回400 ，所以required的意思是這個欄位不能缺，但是有沒有vlan tag就是由slice的內容來決定
hwchiu
reviewed
Jul 13, 2018
src/server/handler_network_test.go
Outdated
| @@ -55,10 +55,12 @@ func (suite *NetworkTestSuite) TestCreateNetwork() { | |||
| network := entity.Network{ | |||
| Type: entity.FakeNetworkType, | |||
| Name: tName, | |||
| IsDPDKPort: true, // for fake network, true means success | |||
There was a problem hiding this comment.
please change the way how fake network works.
Codecov Report
@@ Coverage Diff @@
## develop #96 +/- ##
===========================================
- Coverage 56.13% 56.05% -0.09%
===========================================
Files 35 35
Lines 1564 1561 -3
===========================================
- Hits 878 875 -3
+ Misses 630 629 -1
- Partials 56 57 +1
Continue to review full report at Codecov.
|
John-Lin
force-pushed
the
johnlin/validate-network-entity
branch
from
e8cb6b3 to
25f63c0
Compare
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
…ntity VX-175 valitate network entity before insert Former-commit-id: 0f7c4895d403935030df2d0331d9f643a24de3ae [formerly 0c1bff6] Former-commit-id: b971f0ebc5b0b4982ef73b969b7de4e9ade0352d
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
…ntity VX-175 valitate network entity before insert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.