CI: replace test execution handler with conditional #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykim-akamai
requested review from
lgarber-akamai and
zliang-akamai
and removed request for
a team
ykim-akamai
added
the
repo-ci-improvement
lgarber-akamai
approved these changes
May 8, 2024
Comment on lines
+26
to
27
| - name: Update packages | ||
| run: sudo apt-get update -y |
There was a problem hiding this comment.
Suggested change
| - name: Update packages | |
| run: sudo apt-get update -y |
I think we won't need apt update because we already removed theapt install command and we won't use apt anywhere else in this workflow?
zliang-akamai
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Substitute hacky solution of executing integration tests and uploading test data with a more efficient solution using a conditional statement. This enhancement enables us to directly view test output within its associated step :)
Also for ansible, I separated the uploading logic to a different job for clarity. The uploading/processing logic is a bit more complex and different compare to other repos which involves steps to merge all the xmls into one before uploading to the storage
✔️ How to Test
Verified the workflow on forked - https://github.com/ykim-1/ansible_linode/actions/runs/8977320792
TOD link (test instance) - http://198.19.5.79:7272/builds/663972f94f454e00016b8db8?team=DX&buildName=ansible%200.25.7&bld_id=663972f94f454e00016b8db8
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.