Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test #511

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Add integration test #511

merged 5 commits into from
Jun 5, 2024

Conversation

vshanthe
Copy link
Contributor

📝 Description

As part of Test coverage add test cases for User_info and Database_list

What does this PR do and why is this change necessary?
Test coverage

✔️ How to Test

make TEST_ARGS="-v user_info" test
make TEST_ARGS="-v database_list" test
What are the steps to reproduce the issue or verify the changes?
make TEST_ARGS="-v user_info" test
Regarding the current bug, please uncomment the code and run the command mentioned above to observe the error. Once the issue is resolved, we can re-comment the code

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@vshanthe vshanthe requested a review from a team as a code owner May 30, 2024 06:46
@vshanthe vshanthe requested review from jriddle-linode, lgarber-akamai and ykim-akamai and removed request for a team May 30, 2024 06:46
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests are passing locally!
Thanks for adding the user_info test case btw, that'll make resolving the bug much easier 🎉

- name: user_info
block:
- debug:
msg: Skipping for now...(https://jira.linode.com/browse/TPT-2939)
Copy link
Contributor

@ykim-akamai ykim-akamai May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there more graceful way to skip the test instead of commenting it out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope as of now , same has been followed in other test as well. i.e account_info

@vshanthe vshanthe requested a review from ykim-akamai June 3, 2024 05:22
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some merge conflicts but LGTM. GJ!

@vshanthe vshanthe merged commit 92c0ff4 into dev Jun 5, 2024
7 checks passed
@vshanthe vshanthe deleted the add_test branch June 5, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants