-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test #511
Add integration test #511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests are passing locally!
Thanks for adding the user_info
test case btw, that'll make resolving the bug much easier 🎉
- name: user_info | ||
block: | ||
- debug: | ||
msg: Skipping for now...(https://jira.linode.com/browse/TPT-2939) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there more graceful way to skip the test instead of commenting it out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope as of now , same has been followed in other test as well. i.e account_info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some merge conflicts but LGTM. GJ!
📝 Description
As part of Test coverage add test cases for User_info and Database_list
What does this PR do and why is this change necessary?
Test coverage
✔️ How to Test
make TEST_ARGS="-v user_info" test
make TEST_ARGS="-v database_list" test
What are the steps to reproduce the issue or verify the changes?
make TEST_ARGS="-v user_info" test
Regarding the current bug, please uncomment the code and run the command mentioned above to observe the error. Once the issue is resolved, we can re-comment the code
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.